Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert new phenogrid to svg #468

Merged
merged 9 commits into from
Nov 14, 2023
Merged

Convert new phenogrid to svg #468

merged 9 commits into from
Nov 14, 2023

Conversation

vincerubinetti
Copy link
Contributor

@vincerubinetti vincerubinetti commented Nov 3, 2023

  • update phenogrid readme instructions
  • remove some unused fixture json files
  • manually add really large phenogrid compare fixture json
  • upgrade all packages to latest version. msw 1.0 to 2.0 (only major bump). refactor to accommodate.
  • add some missing toLocaleString() to numbers
  • change phenogrid component from table to svg. pros and cons discussed here
  • touchup behavior and look of phenogrid. add basic info tooltip. add transpose feature. rework size event emitting for widget use. download as svg instead of png
  • touchup node page associations section
  • fix small bug where clicking association count link in overview section does not scroll to associations section
  • tweak how async route loading is done to avoid flash of homepage while loading
  • add and tweak util funcs

Please take a look at the fixture data is being generated for the frontend. If it's not being imported at the top of /fixtures/index.ts, it's not being used and doesn't need to be generated.

Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit 10b21fe
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/654ec8af1c975e00084ba39e
😎 Deploy Preview https://deploy-preview-468--monarch-app.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vincerubinetti
Copy link
Contributor Author

Let add/fix a few more things before merging, and I will re-ping @kevinschaper when ready.

@vincerubinetti
Copy link
Contributor Author

@kevinschaper ready

@kevinschaper kevinschaper merged commit a6f7623 into main Nov 14, 2023
9 checks passed
@kevinschaper kevinschaper deleted the phenogrid-svg branch November 14, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants