Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SemsimServer search #499

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Implement SemsimServer search #499

merged 2 commits into from
Dec 13, 2023

Conversation

glass-ships
Copy link
Collaborator

Closes #233

  • Implement in backend
  • Implement in frontend
  • Add fixture data
  • Add tests?

@glass-ships glass-ships self-assigned this Dec 12, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 12, 2023 •
edited
Loading

✅ Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit 767905b
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/6579038122f93e00088a216d
😎 Deploy Preview https://deploy-preview-499--monarch-app.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kevinschaper
Update semsearch to take a search category enumeration value rather t…
767905b 
…han a raw prefix, plus generate fixtures and manually repair the model so that the scores are numbers rather than strings.
@kevinschaper kevinschaper mentioned this pull request Dec 13, 2023
Closed
3 tasks
@kevinschaper kevinschaper self-requested a review December 13, 2023 01:57
kevinschaper
kevinschaper approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@kevinschaper kevinschaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to bring this in and get it working on dev, and then follow on with the UI as its own PR.

@kevinschaper kevinschaper merged commit 3efaf1c into main Dec 13, 2023
10 checks passed
@kevinschaper kevinschaper deleted the search branch December 13, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinschaper kevinschaper kevinschaper approved these changes

Assignees

@glass-ships glass-ships

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement similarity search using OAK
2 participants
@glass-ships @kevinschaper