remove old ssh keys in action #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for monarch-app canceled.
|
falquaddoomi
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Looks reasonable to me! Nothing blocking merging AFAICT.
One thing that might aid readability is adding in newlines; since you're using a YAML block (indicated by the | after run: ) you should be able to use newlines just fine.
I also see that you opted for the version that doesn't filter by account, but I guess you only see the keys for the currently-activated account when you run gcloud compute os-login ssh-keys list? If that's the case, then I suppose it'll only get rid of its own keys, so that's probably fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address issue with update-gcp action failing