Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Taxon, adjust positioning #692

Merged
merged 2 commits into from
May 15, 2024
Merged

Add Taxon, adjust positioning #692

merged 2 commits into from
May 15, 2024

Conversation

amc-corey-cox
Copy link
Collaborator

Related issues

Summary

  • adds Taxon to gene search results
  • changes spacing and flow of Title components on search results page
  • fixes Users unable to identify gene differences without clicking through or decoding curies

Checks

  • All tests have passed (or issues created for failing tests)

@amc-corey-cox amc-corey-cox linked an issue May 14, 2024 that may be closed by this pull request
Copy link

netlify bot commented May 14, 2024

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit c2150d1
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/6643b845b0e0730008e7cb16
😎 Deploy Preview https://deploy-preview-692--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.74%. Comparing base (f4b28e1) to head (c2150d1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   70.74%   70.74%           
=======================================
  Files          91       91           
  Lines        3073     3073           
=======================================
  Hits         2174     2174           
  Misses        899      899           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amc-corey-cox
Copy link
Collaborator Author

Here is an example of how it looks for a quick review (using the above netlify link).

https://deploy-preview-692--monarch-app.netlify.app/explore?search=pdrG1#search

@kevinschaper kevinschaper merged commit fca0ed6 into main May 15, 2024
11 checks passed
@kevinschaper kevinschaper deleted the 688_gene_taxon branch May 15, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Taxon to results list in gene search.
3 participants