-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove spacy dependancy in pyproject.toml #913
Conversation
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
==========================================
+ Coverage 71.14% 71.17% +0.02%
==========================================
Files 91 91
Lines 3136 3167 +31
==========================================
+ Hits 2231 2254 +23
- Misses 905 913 +8 ☔ View full report in Codecov by Sentry. |
Hey @madanucd, are there any substantial changes in those last three commits? I think you may not have pulled from |
Hi @ptgolden The only updates in this branch are to the following files:
The Merging If cherry-picking the relevant commit works better for you, please feel free to proceed. Alternatively, I can create a clean branch and submit a new PR to ensure clarity, deleting this branch and the current PR. Please let me know how. |
New PR in #920 👍 |
Copied from #913 from @madanucd ### Related issues - Closes #809 ### Summary This PR addresses dependency issues with `monarch-py` deployment to PyPI, fixing errors caused by direct dependencies on external URLs for spacy `en_core_sci_sm` model. - Utilized pystow to download and cache the en_core_sci_sm model from an S3 URL. - Implemented automatic unpacking and dynamic directory identification to ensure the model is properly extracted and loaded. ### Checks - [x] All annotation backend tests were checked and successfully passed. - [x] Completed testing of the API development environment to ensure proper integration. --------- Co-authored-by: madanucd <madan@tislab.org> Co-authored-by: Patrick Golden <ptgolden@email.unc.com>
Related issues
Summary
This PR addresses dependency issues with
monarch-py
deployment to PyPI, fixing errors caused by direct dependencies on external URLs for spacyen_core_sci_sm
model.Utilized pystow to download and cache the en_core_sci_sm model from an S3 URL.
Implemented automatic unpacking and dynamic directory identification to ensure the model is properly extracted and loaded.
Checks