Update orthology association table #930
Conversation
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
==========================================
+ Coverage 71.14% 71.26% +0.11%
==========================================
Files 91 91
Lines 3136 3149 +13
==========================================
+ Hits 2231 2244 +13
Misses 905 905 ☔ View full report in Codecov by Sentry. |
| "-c", | ||
| help="A comma-separated list of counterpart categories" | ||
| ), | ||
| typer.Option("--counterpart-category", "-c", help="A comma-separated list of counterpart categories"), |
There was a problem hiding this comment.
This was autoformatting from make format
| entity_id: Annotated[ | ||
| str, typer.Argument(help="The entity to get association counts for") | ||
| ], | ||
| entity_id: Annotated[str, typer.Argument(help="The entity to get association counts for")], | ||
| fmt: fields.FormatOption = fields.OutputFormat.json, | ||
| output: fields.OutputOption = None, | ||
| ): |
| .th:nth-child(3) { | ||
| width: 30%; | ||
| } | ||
|
|
||
| /** body cells */ |
There was a problem hiding this comment.
This is where I might be causing trouble by altering potentially broader impact css, but I think I'm actually reducing the trouble that this overly broad css was causing. This PR is the first of many for defining the columns for each association type separately, and it doesn't make sense that we'll always want these widths. Plus, if you scan through Human Disease on this branch, most tables look better, in particular it gives as much space as possible to disease models.
| :breadcrumbs="getBreadcrumbs(node, row, 'object')" | ||
| /> | ||
| </template> | ||
|
|
||
| <!-- subject --> |
There was a problem hiding this comment.
how to display an ortholog cell
| >{{ source.id }}</AppLink | ||
| > | ||
| </template> | ||
|
|
There was a problem hiding this comment.
how to display a has_evidence cell (borrowed from SectionAssociationDetails)
| }, | ||
| ]; | ||
| }); | ||
|
|
There was a problem hiding this comment.
which columns should be shown for the ortholog section
A first try at largely keeping our existing association table infrastructure but defining each section separately, doing the ortholog table specifically.