fix(MenuItem): change condition of ariaLabel (#1939)

mondaycom · Feb 11, 2024 · dd46c24 · dd46c24
1 parent 28dff21
commit dd46c24
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/components/Menu/MenuItem/MenuItem.tsx b/src/components/Menu/MenuItem/MenuItem.tsx
@@ -85,7 +85,7 @@ export interface MenuItemProps extends VibeComponentProps {
 
 interface MenuItemTitleComponentProps extends Omit<MenuItemProps, "title"> {
   title: ReactElement;
-  "aria-label": AriaAttributes["aria-label"];
+  "aria-label": NonNullable<AriaAttributes["aria-label"]>;
 }
 
 const MenuItem: VibeComponent<MenuItemProps | MenuItemTitleComponentProps> & {
@@ -238,7 +238,7 @@ const MenuItem: VibeComponent<MenuItemProps | MenuItemTitleComponentProps> & {
     );
 
     // if "title" is a component ariaLabel is mandatory
-    const iconLabel = ariaLabel || (title as string);
+    const iconLabel = ariaLabel ?? (title as string);
     const renderSubMenuIconIfNeeded = () => {
       if (!hasChildren) return null;