Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MenuItem): change condition of ariaLabel #1939

Merged
merged 1 commit into from
Feb 11, 2024
Merged

fix(MenuItem): change condition of ariaLabel #1939

merged 1 commit into from
Feb 11, 2024

Conversation

talkor
Copy link
Member

@talkor talkor commented Feb 8, 2024

@talkor talkor requested a review from a team as a code owner February 8, 2024 16:28
YossiSaadi
YossiSaadi approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!!

@talkor talkor merged commit dd46c24 into master Feb 11, 2024
12 checks passed
@talkor talkor deleted the fix/menu-item/fix-aria-label-condition branch February 11, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YossiSaadi YossiSaadi YossiSaadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talkor @YossiSaadi