Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ aws.sqs.queues resource #4030

Merged
merged 8 commits into from
May 28, 2024
Merged

✨ aws.sqs.queues resource #4030

merged 8 commits into from
May 28, 2024

Conversation

vjeffrey
Copy link
Contributor

Screenshot 2024-05-18 at 16 38 39

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 18, 2024 •
edited
Loading

Test Results

3 031 tests  ±0   3 030 ✅ ±0   1m 25s ⏱️ +6s
  337 suites ±0       1 💤 ±0 
   24 files   ±0       0 ❌ ±0 

Results for commit 67b6ba7. ± Comparison against base commit b7f2c89.

♻️ This comment has been updated with latest results.

@vjeffrey vjeffrey mentioned this pull request May 19, 2024
Merged
misterpantz
misterpantz reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@misterpantz misterpantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look great! Just 2 suggestions :)

providers/aws/resources/aws.lr Outdated Show resolved Hide resolved
providers/aws/resources/aws.lr Outdated Show resolved Hide resolved
@vjeffrey vjeffrey force-pushed the vj/newresources17may branch 2 times, most recently from 059726e to 141914c Compare May 24, 2024 00:30
@vjeffrey vjeffrey force-pushed the vj/newresources17may branch from cf55044 to 7812a58 Compare May 28, 2024 16:47
@vjeffrey vjeffrey force-pushed the vj/newresources17may branch from 7812a58 to fc068be Compare May 28, 2024 16:53
@tas50
Add back the package
67b6ba7 
Signed-off-by: Tim Smith <tsmith84@gmail.com>
@tas50 tas50 merged commit dc5835c into main May 28, 2024
14 checks passed
@tas50 tas50 deleted the vj/newresources17may branch May 28, 2024 19:32
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@misterpantz misterpantz misterpantz left review comments

@tas50 tas50 tas50 left review comments

@preslavgerchev preslavgerchev preslavgerchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vjeffrey @tas50 @preslavgerchev @misterpantz