🧹 Adding Country location to NamedLocation under conditional access - MS365 #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HRouhani
commented
Nov 13, 2024
•
HRouhani
commented
tas50
changed the title
czunker
reviewed
Nov 13, 2024
| @@ -60,6 +60,8 @@ microsoft.tenant @defaults("name") { | |||
| microsoft.conditionalAccess { | |||
| // IP named location | |||
| namedLocations() []microsoft.conditionalAccess.ipNamedLocation | |||
| // Country-based named location | |||
| countryLocations() []microsoft.conditionalAccess.countryNamedLocation | |||
There was a problem hiding this comment.
From reading the docs, I think, this should be called namedLocations(). It can be a country or an IP.
There was a problem hiding this comment.
Good points. I changed the structure totally to make it both be under the umbrella of namedLocation
| @@ -70,6 +72,14 @@ microsoft.conditionalAccess.ipNamedLocation @defaults("name trusted") { | |||
| trusted bool | |||
| } | |||
|
|
|||
| // Microsoft Conditional Access Country named location | |||
| microsoft.conditionalAccess.countryNamedLocation @defaults("name lookupMethod") { | |||
There was a problem hiding this comment.
Same here:
namedLocation instead of country...
|
After the merging I need to change all the policies get effected with this changes! |
czunker
reviewed
Nov 13, 2024
| } | ||
|
|
||
| ctx := context.Background() | ||
| namedLocations, err := graphClient.Identity().ConditionalAccess().NamedLocations().Get(ctx, nil) |
There was a problem hiding this comment.
You should check the error here.
| @@ -20,9 +20,6 @@ func (a *mqlMicrosoftConditionalAccess) namedLocations() ([]interface{}, error) | |||
|
|
|||
| ctx := context.Background() | |||
| namedLocations, err := graphClient.Identity().ConditionalAccess().NamedLocations().Get(ctx, nil) | |||
| if err != nil { | |||
There was a problem hiding this comment.
I think, you should keep the err check.
czunker
approved these changes
Nov 13, 2024
… MS365 Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
HRouhani
force-pushed
the
hossein/ms365-conditionalAccess-country
branch
from
e518ac6 to
88ca6ba
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.