-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Adding Country location to NamedLocation under conditional access - MS365 #4848
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,8 +58,16 @@ microsoft.tenant @defaults("name") { | |
|
||
// Microsoft Conditional Access Policies | ||
microsoft.conditionalAccess { | ||
// IP named location | ||
namedLocations() []microsoft.conditionalAccess.ipNamedLocation | ||
// Named locations container | ||
namedLocations microsoft.conditionalAccess.namedLocations | ||
} | ||
|
||
// Container for Microsoft Conditional Access Named Locations | ||
microsoft.conditionalAccess.namedLocations { | ||
// IP-based named locations | ||
ipLocations() []microsoft.conditionalAccess.ipNamedLocation | ||
// Country-based named locations | ||
countryLocations() []microsoft.conditionalAccess.countryNamedLocation | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From reading the docs, I think, this should be called There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good points. I changed the structure totally to make it both be under the umbrella of namedLocation |
||
} | ||
|
||
// Microsoft Conditional Access IP named location | ||
|
@@ -70,6 +78,14 @@ microsoft.conditionalAccess.ipNamedLocation @defaults("name trusted") { | |
trusted bool | ||
} | ||
|
||
// Microsoft Conditional Access Country named location | ||
microsoft.conditionalAccess.countryNamedLocation @defaults("name lookupMethod") { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks I did |
||
// Named location name | ||
name string | ||
// Method to determine the country location | ||
lookupMethod string | ||
} | ||
|
||
// Microsoft Entra ID user | ||
private microsoft.user @defaults("id displayName userPrincipalName") { | ||
// User Object ID | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should check the error here.