🛠️ new logger/zerologadapter for retryable requests
#4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the `retryablehttp` package to retry http requests and we always want the logs to go to `debug` level so, we need an adapter. We have implemented this adapter many times, this change removes all the duplicated code and creates a util package that all providers can use. Example: ```go retryClient := retryablehttp.NewClient() retryClient.Logger = zerologadapter.New(log.Logger) ``` Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
preslavgerchev
approved these changes
Nov 21, 2024
|
Just rebase on main. |
chris-rock
reviewed
Nov 21, 2024
| // Copyright (c) Mondoo, Inc. | ||
| // SPDX-License-Identifier: BUSL-1.1 | ||
|
|
||
| package zerologadapter |
There was a problem hiding this comment.
I think this package should be in https://github.com/mondoohq/cnquery/tree/main/logger
There was a problem hiding this comment.
I put it inside the providers-sdk/v1 to make it clear that providers can and should use it, Ill move it though.
Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
afiune
force-pushed
the
afiune/zerolog-adapter
branch
from
e297c61
to
d0dc2e8
Compare
afiune
changed the title
util/zerologadapter for retryable requestslogger/zerologadapter for retryable requests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the
retryablehttppackage to retry http requests and we always want the logs to go todebuglevel so, we need an adapter.We have implemented this adapter many times, this change removes all the duplicated code and creates a util package that all providers can use.
Example: