Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Unsupported cnspec configuration format (YAML) #71

Closed
afiune opened this issue Nov 17, 2024 · 0 comments · Fixed by #72
Closed

🐛 Unsupported cnspec configuration format (YAML) #71

afiune opened this issue Nov 17, 2024 · 0 comments · Fixed by #72
Assignees
@afiune

Comments

@afiune
Copy link
Contributor

afiune commented Nov 17, 2024

The configuration file for cnspec can be provided in two formats, JSON and YAML.

https://mondoo.com/docs/cnspec/cnspec-adv-install/registration/

We currently only support JSON, we need to fix the signer to also load YAML files.

Acceptance Criteria

When creating a Mondoo client, we should be able to load the configuration file in YAML format.
@afiune afiune self-assigned this Nov 17, 2024
afiune added a commit that referenced this issue Nov 17, 2024
@afiune
🐛 Load configuration files in YAML format
a4d5f98 
Closes #71

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
@afiune afiune mentioned this issue Nov 17, 2024
Merged
afiune added a commit that referenced this issue Nov 17, 2024
@afiune
🐛 Load configuration files in YAML format
1892d0e 
Closes #71

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
chris-rock pushed a commit that referenced this issue Nov 18, 2024
@afiune
🐛 Load configuration files in YAML format (#72)
6aa14c6 
* 🐛 Load configuration files in YAML format

Closes #71

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>

* ↪️  swap yaml package to sigs.k8s.io/yaml

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>

---------

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
afiune added a commit to mondoohq/terraform-provider-mondoo that referenced this issue Nov 19, 2024
@afiune
🧹 update mondoo-go to loading YAML config files
6010965 
Because of mondoohq/mondoo-go#71

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
@afiune afiune mentioned this issue Nov 19, 2024
Merged
afiune added a commit to mondoohq/terraform-provider-mondoo that referenced this issue Nov 19, 2024
@afiune
🧹 update mondoo-go to loading YAML config files
e506545 
Because of mondoohq/mondoo-go#71

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
chris-rock pushed a commit to mondoohq/terraform-provider-mondoo that referenced this issue Nov 19, 2024
@afiune
🧹 update mondoo-go to fix loading of YAML config files (#156)
24524a7 
* 🧹 update mondoo-go to loading YAML config files

Because of mondoohq/mondoo-go#71

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>

* 📝 fix typo

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>

---------

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afiune afiune

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Load configuration files in YAML format mondoohq/mondoo-go
1 participant
@afiune