🐛 Load configuration files in YAML format #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #71 Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
afiune
force-pushed
the
afiune/71/support-YAML
branch
from
a4d5f98
to
1892d0e
Compare
chris-rock
requested changes
Nov 18, 2024
go.mod
Outdated
| @@ -7,11 +7,11 @@ require ( | |||
| github.com/shurcooL/graphql v0.0.0-20230722043721-ed46e5a46466 | |||
| github.com/stretchr/testify v1.9.0 | |||
| golang.org/x/oauth2 v0.23.0 | |||
| gopkg.in/yaml.v3 v3.0.1 | |||
There was a problem hiding this comment.
Generally we use https://github.com/kubernetes-sigs/yaml which uses json also for yaml fields. I recommend we put gokpg.in/yaml.v3 on our blocking list and use https://github.com/kubernetes-sigs/yaml instead
internal/signer/signer.go
Outdated
| PrivateKey string `json:"private_key,omitempty"` | ||
| Certificate string `json:"certificate,omitempty"` | ||
| ApiEndpoint string `json:"api_endpoint,omitempty"` | ||
| Mrn string `json:"mrn,omitempty" yaml:"mrn,omitempty"` |
There was a problem hiding this comment.
With the switch to https://github.com/kubernetes-sigs/yaml this change is not required.
There was a problem hiding this comment.
Will switch! Thanks, @chris-rock 👍🏽
Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
afiune
force-pushed
the
afiune/71/support-YAML
branch
from
7d55e60
to
80d435c
Compare
chris-rock
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Great improvement, thank you for the additional tests @afiune
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change is merged, we need to update our Terraform provider since that is
where I found this bug.
With a valid Service Account in YAML format, I got:
With this change, I am able to use the YAML config file. ⭐
Closes #71