Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Android #4294

Merged
merged 3 commits into from
Sep 4, 2018
Merged

Fixes for Android #4294

merged 3 commits into from
Sep 4, 2018

Conversation

MoroccanMalinois
Copy link
Contributor

includes fix for #3056

Followed instructions here

@luigi1111 luigi1111 merged commit 339a23a into monero-project:master Sep 4, 2018
luigi1111 added a commit that referenced this pull request Sep 4, 2018
@luigi1111
Merge pull request #4294
39bcb97 
620105e Translations: handle cross compiling (MoroccanMalinois)
fa814af Build: Fix target release-static-android (MoroccanMalinois)
339a23a Docker: Fix android build (MorrocanMalinois)
iDunk5400 added a commit to iDunk5400/monero that referenced this pull request Sep 4, 2018
@iDunk5400
Windows: tell cmake it's not crosscompiling in MSYS2
6b4f08c 
This fixes a cmake error in MSYS2 introduced by monero-project#4294
@iDunk5400 iDunk5400 mentioned this pull request Sep 4, 2018
Closed
@iDunk5400 iDunk5400 mentioned this pull request Sep 6, 2018
Merged
iDunk5400 added a commit to iDunk5400/monero that referenced this pull request Sep 6, 2018
@iDunk5400
Windows: don't preset CMAKE_SYSTEM_NAME
6929b52 
Let it be autodiscovered instead to avoid cmake thinking it's crosscompiling builds where host = target. This resolves a cmake configure error in MSYS2 caused by CMAKE_CROSSCOMPILING checks in monero-project#4294.
@MoroccanMalinois MoroccanMalinois deleted the android branch September 9, 2018 15:20
stoffu pushed a commit to stoffu/monero that referenced this pull request Dec 17, 2018
@iDunk5400 @stoffu
Windows: don't preset CMAKE_SYSTEM_NAME /monero#4342
c6d1b3f 
Let it be autodiscovered instead to avoid cmake thinking it's crosscompiling builds where host = target. This resolves a cmake configure error in MSYS2 caused by CMAKE_CROSSCOMPILING checks in monero-project#4294.
@stoffu stoffu mentioned this pull request Dec 17, 2018
Merged
@selsta selsta mentioned this pull request Apr 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moneromooo-monero moneromooo-monero moneromooo-monero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoroccanMalinois @moneromooo-monero @luigi1111