Windows: don't preset CMAKE_SYSTEM_NAME #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moneromooo-monero
approved these changes
Sep 6, 2018
|
I think there is no such danger presently. The way I understand it, one would have to make a new Makefile target and build translations natively before building Monero itself to take advantage of MorrocanMalinois' crosscompiling changes. But maybe there is still something I'm missing. |
Let it be autodiscovered instead to avoid cmake thinking it's crosscompiling builds where host = target. This resolves a cmake configure error in MSYS2 caused by CMAKE_CROSSCOMPILING checks in monero-project#4294.
iDunk5400
force-pushed
the
win-cmake-cc2
branch
from
67584ab
to
6929b52
Compare
|
I force pushed a change that will save anyone making a crosscompile Windows target from having to add |
MoroccanMalinois
approved these changes
Sep 6, 2018
danrmiller
approved these changes
Sep 9, 2018
fluffypony
added a commit
that referenced
this pull request
Sep 11, 2018
6929b52 Windows: don't preset CMAKE_SYSTEM_NAME (iDunk5400)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let it be autodiscovered instead to avoid cmake thinking it's crosscompiling builds where host = target. This resolves a cmake configure error in MSYS2 caused by CMAKE_CROSSCOMPILING checks in #4294