cryptonote: sort tx_extra fields #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moneromooo-monero
force-pushed
the
sort_tx_extra
branch
from
ac20300 to
d46adcd
Compare
|
Changed to append any unparsed data at the end if allow_partial is set, as this is more useful. |
moneromooo-monero
force-pushed
the
sort_tx_extra
branch
from
d46adcd to
0120068
Compare
This removes some small amount of fingerprinting entropy. There is no consensus rule to require this since this field is technically free form, and a transaction is free to have custom data in it.
moneromooo-monero
force-pushed
the
sort_tx_extra
branch
from
0120068 to
9907ea0
Compare
stoffu
approved these changes
Oct 23, 2018
fluffypony
added a commit
that referenced
this pull request
Oct 26, 2018
9907ea0 cryptonote: sort tx_extra fields (moneromooo-monero)
stoffu
pushed a commit
to stoffu/monero
that referenced
this pull request
Oct 29, 2021
This removes some small amount of fingerprinting entropy. There is no consensus rule to require this since this field is technically free form, and a transaction is free to have custom data in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some small amount of fingerprinting entropy.
There is no consensus rule to require this since this field
is technically free form, and a transaction is free to have
custom data in it.