Aeon upstream 13 #247
Merged
Aeon upstream 13 #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoffu
commented
Oct 26, 2021
•
stoffu
commented
- wallet2: extend fake out picks away from the gamma pick monero-project/monero#4697
- cryptonote: sort tx_extra fields monero-project/monero#4308
- Translate all contexts but simple_wallet for Japanese, translate 23% of simple_wallet for Japanese monero-project/monero#4513
- Add gitian build script monero-project/monero#4526
- blocks: use auto-generated .c files instead of 'LD -r -b binary' monero-project/monero#4536
- wallet_rpc_server: add describe_transfer RPC monero-project/monero#4539
- Windows: improve version detection monero-project/monero#4545
- simplewallet: fixed deadlock if a user hits CTRL+C twice monero-project/monero#4547
- wallet_rpc_server: optionally return tx keys in sign_transfer monero-project/monero#4552
- simplewallet: perform trivial error checks before password prompt monero-project/monero#4555
- Return appropriate RPC error code when key image signature check fails monero-project/monero#4561
- readline_buffer: fix "cursor in prompt" bug monero-project/monero#4573
…-project#4697 in order to unbias selection from blocks with few txes This change is irrelevant for Aeon as it applies to RingCT transactions only. Brought here only to maintain code similarity. (Stoffu)
This removes some small amount of fingerprinting entropy. There is no consensus rule to require this since this field is technically free form, and a transaction is free to have custom data in it.
…and "Wallet" Contexts monero/monero-project#4513
The gitian environment does not treat whitespaces in configure lines, like most other systems. The solution is to just remove them.
This adds a build script to run gitian builds for linux. The build script was copied from bitcoin and then adapted for monero. Build step documentation is outlined in the README in the contrib/gitian directory. (from stoffu) These files are copied without being adapted for aeon. Making gitian build work for aeon will be addressed later.
The signature prepare tool and the gitian-builder git repo should be checked for their content. For this purpose, checkout the gitian-builder repo at a specific commit and take the sha256sum of the osslsigncode tool.
Windows is built with a seperate descriptor to handle additional changes that need to be done to the end binary. Consolidate the gitian-build script for this change.
…project#4526 The sigs should be produced in a seperate step by default. Remove windows and osx sig options that are not needed for monero.
stoffu
force-pushed
the
aeon-upstream-13
branch
from
2b7c51e to
d5b4953
Compare
for unsigned tx sets using a view only wallet
…o-project#4547 Co-authored-by: moneromooo-monero <moneromooo-monero@users.noreply.github.com>
It happens when readline displays a prompt just before switching to a shorter one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.