blocks: use auto-generated .c files instead of 'LD -r -b binary' #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiphon
force-pushed
the
libblocks-auto-generated-c-files
branch
2 times, most recently
from
4508ada to
fb9fb63
Compare
xiphon
changed the title
xiphon
force-pushed
the
libblocks-auto-generated-c-files
branch
7 times, most recently
from
b58d7b4 to
7db4799
Compare
xiphon
changed the title
|
Rebased, ready to merge |
|
@moneromooo-monero |
|
Weird, I'm pretty sure I typed a review comment. It's about making the std::function parameters const refs, as they can get largeish. |
xiphon
force-pushed
the
libblocks-auto-generated-c-files
branch
2 times, most recently
from
bd04aa7 to
5c12b0c
Compare
|
There's at least a couple which are still not, functions in core and Blockchain. |
|
Kinda hard to guess what lines we are talking about. Feel free to comment on these lines. |
xiphon
force-pushed
the
libblocks-auto-generated-c-files
branch
from
5c12b0c to
fd62b6e
Compare
|
Thanks, done |
fluffypony
added a commit
that referenced
this pull request
Oct 26, 2018
fd62b6e blocks: use auto-generated .c files instead of 'LD -r -b binary' (xiphon)
stoffu
pushed a commit
to stoffu/monero
that referenced
this pull request
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #4472 + Fixes OSX compilation