build: fixed submodule check #4620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiphon
force-pushed
the
fix-submodule-check
branch
3 times, most recently
from
a47501f
to
ad4cce9
Compare
moneromooo-monero
approved these changes
Oct 16, 2018
anonimal
approved these changes
Oct 16, 2018
|
Tested by patching the latest master with this and doing a static-win64 compile. Seems to work: it properly fails if external folder is missing; otherwise detects each submodule folder and continues on. |
fluffypony
added a commit
that referenced
this pull request
Oct 26, 2018
ad4cce9 build: fixed submodule check (xiphon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4616