feat!: Update ESLint version requirements #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakamsha
force-pushed
the
feat/eslint-version-requirements
branch
from
91a03a9 to
50f3283
Compare
|
This PR is frozen as a Draft until #338 is merged. |
wakamsha
force-pushed
the
feat/eslint-version-requirements
branch
from
50f3283 to
fc1fa32
Compare
7 tasks
|
This PR is frozen as a Draft until #355 is merged. |
update snapshot
wakamsha
force-pushed
the
feat/eslint-version-requirements
branch
from
a93d119 to
7c7e949
Compare
wakamsha
force-pushed
the
feat/eslint-version-requirements
branch
from
7c7e949 to
630a9c5
Compare
wakamsha
commented
Dec 9, 2024
There was a problem hiding this comment.
It seems that the output of rule settings has changed since ESLint was upgraded to v9.
In v8, all options were output, but in v9, unspecified options are no longer output. Since these two options were not specified and left at the default values, it seems that they are no longer output.
| @@ -55,15 +55,15 @@ | |||
| "eslint-plugin-react-hooks": "^5.0.0", | |||
| "eslint-plugin-storybook": "^0.11.1", | |||
| "eslint-plugin-testing-library": "^7.0.0", | |||
| "eslint-plugin-unicorn": "^56.0.0", | |||
| "eslint-plugin-unicorn": "^56.0.1", | |||
There was a problem hiding this comment.
When used in combination with ESLint v9.15.0 or higher, lint will fail, so you need to update eslint-plugin-unicorn.
oss-frontend-github-app bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
## [5.0.0](4.1.2...5.0.0) (2024-12-10) ### ⚠ BREAKING CHANGES * Update ESLint version requirements (#354) * Update TypeScript Rules and Config to support ESLint v9 (#338) * Update eslint-plugin-next version (#353) * Update eslint-plugin-testing-library version (#351) * Update eslint-plugin-react-hooks version (#349) * Update eslint-plugin-jsdoc version (#346) * Update eslint-plugin-promise version (#345) * Update eslint-plugin-import version (#344) * Add a ruleset powered by `unicorn` plugin into `essentials` config (#335) ### Features * Add a ruleset powered by `unicorn` plugin into `essentials` config ([#335](#335)) ([c5a1544](c5a1544)) * Update ESLint version requirements ([#354](#354)) ([78aa086](78aa086)) * Update eslint-plugin-import version ([#344](#344)) ([37927c4](37927c4)) * Update eslint-plugin-jest version ([#342](#342)) ([5beb961](5beb961)) * Update eslint-plugin-jest-dom version ([#343](#343)) ([e803148](e803148)) * Update eslint-plugin-jsdoc version ([#346](#346)) ([9e0cf74](9e0cf74)) * Update eslint-plugin-jsx-a11y version ([#348](#348)) ([85f8fe9](85f8fe9)) * Update eslint-plugin-n version ([#347](#347)) ([3d78df4](3d78df4)) * Update eslint-plugin-next version ([#353](#353)) ([e906b76](e906b76)) * Update eslint-plugin-promise version ([#345](#345)) ([e7abb32](e7abb32)) * Update eslint-plugin-react version ([#350](#350)) ([6c8551c](6c8551c)) * Update eslint-plugin-react-hooks version ([#349](#349)) ([22f5358](22f5358)) * Update eslint-plugin-storybook version ([#352](#352)) ([2171394](2171394)) * Update eslint-plugin-testing-library version ([#351](#351)) ([ca2bcec](ca2bcec)) * Update TypeScript Rules and Config to support ESLint v9 ([#338](#338)) ([b945312](b945312))
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
To support ESLint v9, most plugins need to be updated. This will also change the minimum required version of ESLint.
Linked PR / Issues
Type of change
Pre-flight checklist
References