Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update ESLint version requirements #354

Merged
merged 3 commits into from
Dec 10, 2024
Merged

feat!: Update ESLint version requirements #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e57aab
feat!: Update ESLint version requirements
wakamsha Dec 2, 2024
a266c14
fix eslint error
wakamsha Dec 9, 2024
630a9c5
update snapshot
wakamsha Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
416 changes: 228 additions & 188 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@
"eslint-plugin-react-hooks": "^5.0.0",
"eslint-plugin-storybook": "^0.11.1",
"eslint-plugin-testing-library": "^7.0.0",
"eslint-plugin-unicorn": "^56.0.0",
"eslint-plugin-unicorn": "^56.0.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When used in combination with ESLint v9.15.0 or higher, lint will fail, so you need to update eslint-plugin-unicorn.

see: sindresorhus/eslint-plugin-unicorn#2497

"globals": "^15.11.0",
"typescript-eslint": "^8.16.0"
},
"devDependencies": {
"@semantic-release/changelog": "6.0.3",
"@semantic-release/git": "10.0.1",
"conventional-changelog-conventionalcommits": "8.0.0",
"eslint": "8.57.0",
"eslint": "9.16.0",
"eslint-config-prettier": "9.1.0",
"jest": "29.7.0",
"prettier": "3.4.2",
Expand All @@ -72,7 +72,7 @@
"typescript": "5.7.2"
},
"peerDependencies": {
"eslint": "^8.56.0",
"eslint": "^8.57.0 || ^9.0.0",
"jest": "*",
"typescript": "^4.8.4 || ^5.0.0"
},
Expand Down
22 changes: 0 additions & 22 deletions tests/snapshot-test/eslintrc/next/__snapshots__/snapshot.test.js.snap
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the output of rule settings has changed since ESLint was upgraded to v9.

In v8, all options were output, but in v9, unspecified options are no longer output. Since these two options were not specified and left at the default values, it seems that they are no longer output.

Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,7 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
"@typescript-eslint/dot-notation": [
2,
{
"allowIndexSignaturePropertyAccess": false,
"allowKeywords": true,
"allowPattern": "",
"allowPrivateClassPropertyAccess": false,
"allowProtectedClassPropertyAccess": false,
},
],
"@typescript-eslint/explicit-function-return-type": [
Expand Down Expand Up @@ -299,7 +295,6 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
"allowShortCircuit": true,
"allowTaggedTemplates": true,
"allowTernary": true,
"enforceForJSX": false,
},
],
"@typescript-eslint/no-unused-vars": [
Expand Down Expand Up @@ -422,8 +417,6 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
2,
{
"allowImplicit": true,
"allowVoid": false,
"checkForEach": false,
},
],
"arrow-body-style": [
Expand All @@ -444,8 +437,6 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
0,
{
"ignoreDestructuring": false,
"ignoreGlobals": false,
"ignoreImports": false,
"properties": "never",
},
],
Expand All @@ -468,7 +459,6 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
"class-methods-use-this": [
2,
{
"enforceForClassFields": true,
"exceptMethods": [],
},
],
Expand Down Expand Up @@ -501,11 +491,7 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
"dot-notation": [
0,
{
"allowIndexSignaturePropertyAccess": false,
"allowKeywords": true,
"allowPattern": "",
"allowPrivateClassPropertyAccess": false,
"allowProtectedClassPropertyAccess": false,
},
],
"eqeqeq": [
Expand Down Expand Up @@ -1339,7 +1325,6 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
],
"newIsCap": true,
"newIsCapExceptions": [],
"properties": true,
},
],
"no-alert": [
Expand Down Expand Up @@ -1494,7 +1479,6 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
{
"allow": [],
"boolean": false,
"disallowTemplateShorthand": false,
"number": true,
"string": true,
},
Expand Down Expand Up @@ -2027,11 +2011,6 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
"allow": [],
"allowAfterSuper": false,
"allowAfterThis": false,
"allowAfterThisConstructor": false,
"allowFunctionParams": true,
"allowInArrayDestructuring": true,
"allowInObjectDestructuring": true,
"enforceInClassFields": false,
"enforceInMethodNames": true,
},
],
Expand Down Expand Up @@ -2074,7 +2053,6 @@ exports[`should match ESLint configuration snapshot: next 1`] = `
"allowShortCircuit": true,
"allowTaggedTemplates": true,
"allowTernary": true,
"enforceForJSX": false,
},
],
"no-unused-labels": [
Expand Down
14 changes: 0 additions & 14 deletions tests/snapshot-test/eslintrc/node/__snapshots__/snapshot.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
2,
{
"allowImplicit": true,
"allowVoid": false,
"checkForEach": false,
},
],
"arrow-body-style": [
Expand All @@ -36,8 +34,6 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
2,
{
"ignoreDestructuring": false,
"ignoreGlobals": false,
"ignoreImports": false,
"properties": "never",
},
],
Expand All @@ -60,7 +56,6 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
"class-methods-use-this": [
2,
{
"enforceForClassFields": true,
"exceptMethods": [],
},
],
Expand Down Expand Up @@ -94,7 +89,6 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
2,
{
"allowKeywords": true,
"allowPattern": "",
},
],
"eqeqeq": [
Expand Down Expand Up @@ -476,7 +470,6 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
],
"newIsCap": true,
"newIsCapExceptions": [],
"properties": true,
},
],
"no-alert": [
Expand Down Expand Up @@ -631,7 +624,6 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
{
"allow": [],
"boolean": false,
"disallowTemplateShorthand": false,
"number": true,
"string": true,
},
Expand Down Expand Up @@ -1155,11 +1147,6 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
"allow": [],
"allowAfterSuper": false,
"allowAfterThis": false,
"allowAfterThisConstructor": false,
"allowFunctionParams": true,
"allowInArrayDestructuring": true,
"allowInObjectDestructuring": true,
"enforceInClassFields": false,
"enforceInMethodNames": true,
},
],
Expand Down Expand Up @@ -1202,7 +1189,6 @@ exports[`should match ESLint configuration snapshot: node 1`] = `
"allowShortCircuit": true,
"allowTaggedTemplates": true,
"allowTernary": true,
"enforceForJSX": false,
},
],
"no-unused-labels": [
Expand Down
22 changes: 0 additions & 22 deletions tests/snapshot-test/eslintrc/react/__snapshots__/snapshot.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,7 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
"@typescript-eslint/dot-notation": [
2,
{
"allowIndexSignaturePropertyAccess": false,
"allowKeywords": true,
"allowPattern": "",
"allowPrivateClassPropertyAccess": false,
"allowProtectedClassPropertyAccess": false,
},
],
"@typescript-eslint/explicit-function-return-type": [
Expand Down Expand Up @@ -236,7 +232,6 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
"allowShortCircuit": true,
"allowTaggedTemplates": true,
"allowTernary": true,
"enforceForJSX": false,
},
],
"@typescript-eslint/no-unused-vars": [
Expand Down Expand Up @@ -359,8 +354,6 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
2,
{
"allowImplicit": true,
"allowVoid": false,
"checkForEach": false,
},
],
"arrow-body-style": [
Expand All @@ -381,8 +374,6 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
0,
{
"ignoreDestructuring": false,
"ignoreGlobals": false,
"ignoreImports": false,
"properties": "never",
},
],
Expand All @@ -405,7 +396,6 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
"class-methods-use-this": [
2,
{
"enforceForClassFields": true,
"exceptMethods": [],
},
],
Expand Down Expand Up @@ -438,11 +428,7 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
"dot-notation": [
0,
{
"allowIndexSignaturePropertyAccess": false,
"allowKeywords": true,
"allowPattern": "",
"allowPrivateClassPropertyAccess": false,
"allowProtectedClassPropertyAccess": false,
},
],
"eqeqeq": [
Expand Down Expand Up @@ -1276,7 +1262,6 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
],
"newIsCap": true,
"newIsCapExceptions": [],
"properties": true,
},
],
"no-alert": [
Expand Down Expand Up @@ -1431,7 +1416,6 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
{
"allow": [],
"boolean": false,
"disallowTemplateShorthand": false,
"number": true,
"string": true,
},
Expand Down Expand Up @@ -1964,11 +1948,6 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
"allow": [],
"allowAfterSuper": false,
"allowAfterThis": false,
"allowAfterThisConstructor": false,
"allowFunctionParams": true,
"allowInArrayDestructuring": true,
"allowInObjectDestructuring": true,
"enforceInClassFields": false,
"enforceInMethodNames": true,
},
],
Expand Down Expand Up @@ -2011,7 +1990,6 @@ exports[`should match ESLint configuration snapshot: react 1`] = `
"allowShortCircuit": true,
"allowTaggedTemplates": true,
"allowTernary": true,
"enforceForJSX": false,
},
],
"no-unused-labels": [
Expand Down
22 changes: 0 additions & 22 deletions tests/snapshot-test/eslintrc/storybook/__snapshots__/snapshot.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,7 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
"@typescript-eslint/dot-notation": [
2,
{
"allowIndexSignaturePropertyAccess": false,
"allowKeywords": true,
"allowPattern": "",
"allowPrivateClassPropertyAccess": false,
"allowProtectedClassPropertyAccess": false,
},
],
"@typescript-eslint/explicit-function-return-type": [
Expand Down Expand Up @@ -236,7 +232,6 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
"allowShortCircuit": true,
"allowTaggedTemplates": true,
"allowTernary": true,
"enforceForJSX": false,
},
],
"@typescript-eslint/no-unused-vars": [
Expand Down Expand Up @@ -359,8 +354,6 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
2,
{
"allowImplicit": true,
"allowVoid": false,
"checkForEach": false,
},
],
"arrow-body-style": [
Expand All @@ -381,8 +374,6 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
0,
{
"ignoreDestructuring": false,
"ignoreGlobals": false,
"ignoreImports": false,
"properties": "never",
},
],
Expand All @@ -405,7 +396,6 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
"class-methods-use-this": [
2,
{
"enforceForClassFields": true,
"exceptMethods": [],
},
],
Expand Down Expand Up @@ -438,11 +428,7 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
"dot-notation": [
0,
{
"allowIndexSignaturePropertyAccess": false,
"allowKeywords": true,
"allowPattern": "",
"allowPrivateClassPropertyAccess": false,
"allowProtectedClassPropertyAccess": false,
},
],
"eqeqeq": [
Expand Down Expand Up @@ -1033,7 +1019,6 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
],
"newIsCap": true,
"newIsCapExceptions": [],
"properties": true,
},
],
"no-alert": [
Expand Down Expand Up @@ -1188,7 +1173,6 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
{
"allow": [],
"boolean": false,
"disallowTemplateShorthand": false,
"number": true,
"string": true,
},
Expand Down Expand Up @@ -1721,11 +1705,6 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
"allow": [],
"allowAfterSuper": false,
"allowAfterThis": false,
"allowAfterThisConstructor": false,
"allowFunctionParams": true,
"allowInArrayDestructuring": true,
"allowInObjectDestructuring": true,
"enforceInClassFields": false,
"enforceInMethodNames": true,
},
],
Expand Down Expand Up @@ -1768,7 +1747,6 @@ exports[`should match ESLint configuration snapshot: storybook 1`] = `
"allowShortCircuit": true,
"allowTaggedTemplates": true,
"allowTernary": true,
"enforceForJSX": false,
},
],
"no-unused-labels": [
Expand Down
Loading
Loading