CSHARP-5730: Support static String.Compare method #1789
Conversation
| var strATranslation = ExpressionToAggregationExpressionTranslator.Translate(context, strAExpression); | ||
| var strBExpression = arguments[1]; | ||
| var strBTranslation = ExpressionToAggregationExpressionTranslator.Translate(context, strBExpression); | ||
| var ast = AstExpression.Cmp(strATranslation.Ast, strBTranslation.Ast); |
There was a problem hiding this comment.
Should we add support for case insensitive/more overloads comparison by translating to $strcasecmp?
There was a problem hiding this comment.
I suppose if we do this, we will have to support this compare overload -> https://learn.microsoft.com/en-us/dotnet/api/system.string.compare?view=net-9.0#system-string-compare(system-string-system-string-system-boolean)
| var strATranslation = ExpressionToAggregationExpressionTranslator.Translate(context, strAExpression); | ||
| var strBExpression = arguments[1]; | ||
| var strBTranslation = ExpressionToAggregationExpressionTranslator.Translate(context, strBExpression); | ||
| var ast = AstExpression.Cmp(strATranslation.Ast, strBTranslation.Ast); |
There was a problem hiding this comment.
I suppose if we do this, we will have to support this compare overload -> https://learn.microsoft.com/en-us/dotnet/api/system.string.compare?view=net-9.0#system-string-compare(system-string-system-string-system-boolean)
There was a problem hiding this comment.
Given that this class was extended to support the static string.Compare method, it seems its name is a bit outdated now? I would suggest updating the class name though I don't have a good suggestion maybe StringComparisonExpressionToFilterTranslator?
| throw new ExpressionNotSupportedException(expression); | ||
| } | ||
|
|
||
| private static bool IsStaticCompareMethod(MethodInfo method) |
There was a problem hiding this comment.
The IsStaticCompareMethod doesn't actually check if the method is named "Compare". I doubt this is intentional?
|
|
||
| internal static class AstComparisonFilterOperatorExtensions | ||
| { | ||
| public static AstComparisonFilterOperator GetComparisonOperatorForSwappedLeftAndRight(this AstComparisonFilterOperator @operator) |
There was a problem hiding this comment.
Put here so that it can be used from more than one place.
| return false; | ||
| } | ||
|
|
||
| public static bool IsInstanceCompareToMethod(this MethodInfo method) |
There was a problem hiding this comment.
Put here so that it can be used from more than one place.
|
|
||
| namespace MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToAggregationExpressionTranslators.MethodTranslators | ||
| { | ||
| internal static class CompareMethodToAggregationExpressionTranslator |
There was a problem hiding this comment.
Compare and CompareTo handling is consolidated into a single class.
|
|
||
| namespace MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToFilterTranslators.ExpressionTranslators | ||
| { | ||
| internal static class CompareComparisonExpressionToFilterTranslator |
There was a problem hiding this comment.
Compare and CompareTo handling is consolidated into a single class.
| { | ||
| Expression value1Expression; | ||
| Expression value2Expression; | ||
| if (method.IsStatic) |
There was a problem hiding this comment.
The main difference between Compare and CompareTo is whether it's a static method or not.
|
|
||
| Expression fieldExpression; | ||
| Expression innerValueExpression; | ||
| if (compareMethod.IsStatic) |
There was a problem hiding this comment.
The main difference between Compare and CompareTo is whether it's a static method or not.
| } | ||
| } | ||
|
|
||
| private static AstComparisonFilterOperator GetComparisonOperatorForSwappedLeftAndRight(Expression expression) |
There was a problem hiding this comment.
Moved to an extension method so it can be used from more than one class.
| [InlineData(11, false, "{ $match : { B : { $gte : 'A' } } }", new int[] { 1, 2, 3, 4, 5, 6 })] | ||
| [InlineData(12, false, "{ $match : { B : { $lte : 'A' } } }", new int[] { 1, 3 })] | ||
| [InlineData(1, true, "{ $match : { $expr : { $eq : [{ $strcasecmp : ['A', '$B'] }, -1] } } }", new int[] { 2, 5 })] | ||
| [InlineData(2, true, "{ $match : { $expr : { $eq : [{ $strcasecmp : ['A', '$B'] }, 0] } } }", new int[] { 1, 3, 4, 6 })] |
There was a problem hiding this comment.
This one might have been possible without using $expr by using regular expressions but I don't think it's worth the effort.
|
|
||
| namespace MongoDB.Driver.Tests.Linq.Linq3Implementation.Jira; | ||
|
|
||
| public class CSharp5730Tests : LinqIntegrationTest<CSharp5730Tests.ClassFixture> |
There was a problem hiding this comment.
Do we have tests for CompareTo and IComparable<T>.CompareTo?
|
|
||
| var value1Translation = ExpressionToAggregationExpressionTranslator.Translate(context, value1Expression); | ||
| var value2Translation = ExpressionToAggregationExpressionTranslator.Translate(context, value2Expression); | ||
|
|
There was a problem hiding this comment.
Should we check if the value1 and value2 has string representation?
3 participants
No description provided.