CSHARP-5730: Support static String.Compare method #1789
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /* Copyright 2010-present MongoDB Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System.Linq.Expressions; | ||
| using System.Reflection; | ||
| using MongoDB.Bson.Serialization.Serializers; | ||
| using MongoDB.Driver.Linq.Linq3Implementation.Ast.Expressions; | ||
| using MongoDB.Driver.Linq.Linq3Implementation.ExtensionMethods; | ||
| using MongoDB.Driver.Linq.Linq3Implementation.Misc; | ||
|
|
||
| namespace MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToAggregationExpressionTranslators.MethodTranslators | ||
| { | ||
| internal static class CompareMethodToAggregationExpressionTranslator | ||
|
There was a problem hiding this comment.
|
||
| { | ||
| private static readonly MethodInfo[] __stringCompareMethods = | ||
| [ | ||
| StringMethod.StaticCompare, | ||
| StringMethod.StaticCompareWithIgnoreCase | ||
| ]; | ||
|
|
||
| public static TranslatedExpression Translate(TranslationContext context, MethodCallExpression expression) | ||
| { | ||
| var method = expression.Method; | ||
| var arguments = expression.Arguments; | ||
|
|
||
| if (method.IsStaticCompareMethod() || method.IsInstanceCompareToMethod() || method.IsOneOf(__stringCompareMethods)) | ||
| { | ||
| Expression value1Expression; | ||
| Expression value2Expression; | ||
| if (method.IsStatic) | ||
|
There was a problem hiding this comment. The main difference between |
||
| { | ||
| value1Expression = arguments[0]; | ||
| value2Expression = arguments[1]; | ||
| } | ||
| else | ||
| { | ||
| value1Expression = expression.Object; | ||
| value2Expression = arguments[0]; | ||
| } | ||
|
|
||
| var value1Translation = ExpressionToAggregationExpressionTranslator.Translate(context, value1Expression); | ||
| var value2Translation = ExpressionToAggregationExpressionTranslator.Translate(context, value2Expression); | ||
|
|
||
|
There was a problem hiding this comment. Should we check if the |
||
| AstExpression ast; | ||
| if (method.Is(StringMethod.StaticCompareWithIgnoreCase)) | ||
| { | ||
| var ignoreCaseExpression = arguments[2]; | ||
| var ignoreCase = ignoreCaseExpression.GetConstantValue<bool>(containingExpression: expression); | ||
| ast = ignoreCase | ||
| ? AstExpression.StrCaseCmp(value1Translation.Ast, value2Translation.Ast) | ||
| : AstExpression.Cmp(value1Translation.Ast, value2Translation.Ast); | ||
| } | ||
| else | ||
| { | ||
| ast = AstExpression.Cmp(value1Translation.Ast, value2Translation.Ast); | ||
| } | ||
|
|
||
| return new TranslatedExpression(expression, ast, Int32Serializer.Instance); | ||
| } | ||
|
|
||
| throw new ExpressionNotSupportedException(expression); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| /* Copyright 2010-present MongoDB Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System.Linq.Expressions; | ||
| using MongoDB.Driver.Linq.Linq3Implementation.Ast.Filters; | ||
| using MongoDB.Driver.Linq.Linq3Implementation.ExtensionMethods; | ||
| using MongoDB.Driver.Linq.Linq3Implementation.Misc; | ||
| using MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToFilterTranslators.ToFilterFieldTranslators; | ||
|
|
||
| namespace MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToFilterTranslators.ExpressionTranslators | ||
| { | ||
| internal static class CompareComparisonExpressionToFilterTranslator | ||
|
There was a problem hiding this comment.
|
||
| { | ||
| public static bool CanTranslate(Expression leftExpression) | ||
| { | ||
| return | ||
| leftExpression is MethodCallExpression leftMethodCallExpression && | ||
| leftMethodCallExpression.Method is var method && | ||
| (method.IsStaticCompareMethod() || method.IsInstanceCompareToMethod() || method.Is(StringMethod.StaticCompareWithIgnoreCase)); | ||
| } | ||
|
|
||
| // caller is responsible for ensuring constant is on the right | ||
| public static AstFilter Translate( | ||
| TranslationContext context, | ||
| Expression expression, | ||
| Expression leftExpression, | ||
| AstComparisonFilterOperator outerComparisonOperator, | ||
| Expression rightExpression) | ||
| { | ||
| if (CanTranslate(leftExpression)) | ||
| { | ||
| var compareMethodCallExpression = (MethodCallExpression)leftExpression; | ||
| var compareMethod = compareMethodCallExpression.Method; | ||
| var compareArguments = compareMethodCallExpression.Arguments; | ||
| var outerValue = rightExpression.GetConstantValue<int>(containingExpression: expression); | ||
|
|
||
| Expression fieldExpression; | ||
| Expression innerValueExpression; | ||
| if (compareMethod.IsStatic) | ||
|
There was a problem hiding this comment. The main difference between Compare and CompareTo is whether it's a static method or not. |
||
| { | ||
| fieldExpression = compareArguments[0]; | ||
| innerValueExpression = compareArguments[1]; | ||
| } | ||
| else | ||
| { | ||
| fieldExpression = compareMethodCallExpression.Object; | ||
| innerValueExpression = compareArguments[0]; | ||
| } | ||
|
|
||
| if (compareMethod.Is(StringMethod.StaticCompareWithIgnoreCase)) | ||
| { | ||
| var ignoreCaseExpression = compareArguments[2]; | ||
| var ignoreCase = ignoreCaseExpression.GetConstantValue<bool>(containingExpression: compareMethodCallExpression); | ||
| if (ignoreCase) | ||
| { | ||
| throw new ExpressionNotSupportedException(compareMethodCallExpression, because: "ignoreCase must be false"); | ||
| } | ||
| } | ||
|
|
||
| var fieldComparisonOperator = (outerComparisonOperator, outerValue) switch | ||
| { | ||
| (AstComparisonFilterOperator.Eq, -1) => AstComparisonFilterOperator.Lt, | ||
| (AstComparisonFilterOperator.Ne, -1) => AstComparisonFilterOperator.Gte, | ||
| (AstComparisonFilterOperator.Gt, -1) => AstComparisonFilterOperator.Gte, | ||
| (AstComparisonFilterOperator.Eq, 0) => AstComparisonFilterOperator.Eq, | ||
| (AstComparisonFilterOperator.Ne, 0) => AstComparisonFilterOperator.Ne, | ||
| (AstComparisonFilterOperator.Lt, 0) => AstComparisonFilterOperator.Lt, | ||
| (AstComparisonFilterOperator.Lte, 0) => AstComparisonFilterOperator.Lte, | ||
| (AstComparisonFilterOperator.Gt, 0) => AstComparisonFilterOperator.Gt, | ||
| (AstComparisonFilterOperator.Gte, 0) => AstComparisonFilterOperator.Gte, | ||
| (AstComparisonFilterOperator.Eq, 1) => AstComparisonFilterOperator.Gt, | ||
| (AstComparisonFilterOperator.Ne, 1) => AstComparisonFilterOperator.Lte, | ||
| (AstComparisonFilterOperator.Lt, 1) => AstComparisonFilterOperator.Lte, | ||
| _ => throw new ExpressionNotSupportedException(expression) | ||
| }; | ||
|
|
||
| if (fieldExpression.NodeType == ExpressionType.Constant && innerValueExpression.NodeType != ExpressionType.Constant) | ||
| { | ||
| (fieldExpression, innerValueExpression) = (innerValueExpression, fieldExpression); | ||
| fieldComparisonOperator = fieldComparisonOperator.GetComparisonOperatorForSwappedLeftAndRight(); | ||
| } | ||
|
|
||
| var fieldTranslation = ExpressionToFilterFieldTranslator.Translate(context, fieldExpression); | ||
| var value = innerValueExpression.GetConstantValue<object>(containingExpression: expression); | ||
| var serializedValue = SerializationHelper.SerializeValue(fieldTranslation.Serializer, value); | ||
|
|
||
| return AstFilter.Compare(fieldTranslation.Ast, fieldComparisonOperator, serializedValue); | ||
| } | ||
|
|
||
| throw new ExpressionNotSupportedException(expression); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put here so that it can be used from more than one place.