-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Implement OIDC SASL mechanism in sync #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
driver-sync/src/test/functional/com/mongodb/client/OidcAuthenticationProseTests.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
A few risks associated with this work:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments below are a result of partially reviewing the changes.
driver-core/src/main/com/mongodb/internal/connection/InternalStreamConnection.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/InternalStreamConnection.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/AuthConnectionStringTest.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitting more results of a partial review.
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More results of a partial review.
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/MongoCredentialWithCache.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/MongoCredentialWithCache.java
Outdated
Show resolved
Hide resolved
035843c
to
c64bae2
Compare
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/SaslAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/SaslAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/SaslAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/MongoCredentialWithCache.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/MongoCredentialWithCache.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/MongoCredentialWithCache.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/MongoCredentialWithCache.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/functional/com/mongodb/internal/connection/TestCommandListener.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/functional/com/mongodb/internal/connection/TestCommandListener.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/functional/com/mongodb/internal/connection/TestCommandListener.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/OidcAuthenticationProseTests.java
Outdated
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/OidcAuthenticationProseTests.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Show resolved
Hide resolved
Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
driver-core/src/main/com/mongodb/internal/connection/InternalStreamConnection.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
* Implement OIDC SASL mechanism in sync (#1107) JAVA-4980 * Implement OIDC auth for async (#1131) JAVA-4981 * Remove non-machine workflow (#1259) JAVA-5077 * Add Human OIDC Workflow (#1316) JAVA-5328 * OIDC Add remaining environments (azure, gcp), evergreen testing, API naming updates (#1371) JAVA-5353 JAVA-5395 JAVA-4834 JAVA-4932 Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>
JAVA-4980
For design, see https://docs.google.com/document/d/1TJCIKdmQYjKjsPuh-M42BlcNjhqpgsayJ36cfAiV8y0/edit?pli=1#heading=h.lzf8zc90rp5u
In draft pending the following