Skip to content

Remove non-machine workflow #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 21, 2024
Merged

Remove non-machine workflow #1259

merged 6 commits into from
Feb 21, 2024

Conversation

katcharov
Copy link
Collaborator

@katcharov katcharov commented Nov 15, 2023

JAVA-5077

The spec, including unified/prose tests, still requires changes (only code 18 should be detected; some unified tests rely on this and are not implemented). This PR:

  • Removes IdpInfo, its caching, and the auth principal-request step (making the last phase of the fallback process single-step).
  • Removes the refresh token, its caching, and the "step 2" of the fallback process.
  • Removes the timeout on the access token, making it no longer "single use" but "use until server sends reauth".
  • Removes some tests that test only the above.
  • Changes the external API (naming, adds a version).
  • Refactors
  • Places the lock only on token invalidation and callback invocation, and not server communication.

Outstanding work: some tests are failing on evergreen (need token directory), but pass locally.

katcharov and others added 2 commits February 16, 2024 12:42
Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>
Copy link
Member

@stIncMale stIncMale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@katcharov katcharov requested a review from stIncMale February 20, 2024 19:24
@katcharov katcharov merged commit d460444 into feature-oidc Feb 21, 2024
@katcharov katcharov deleted the JAVA-5077 branch February 21, 2024 22:31
katcharov added a commit that referenced this pull request Mar 4, 2024
* Remove non-machine workflow

* Update prose tests to remove refresh token, principal-request

* Conform to latest spec; remove lock around server auth

* Rebase fix (async API)

* Apply suggestions from code review

Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>

* PR fixes

---------

Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>
katcharov added a commit that referenced this pull request Apr 8, 2024
* Remove non-machine workflow

* Update prose tests to remove refresh token, principal-request

* Conform to latest spec; remove lock around server auth

* Rebase fix (async API)

* Apply suggestions from code review

Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>

* PR fixes

---------

Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>
katcharov added a commit that referenced this pull request Apr 23, 2024
* Remove non-machine workflow

* Update prose tests to remove refresh token, principal-request

* Conform to latest spec; remove lock around server auth

* Rebase fix (async API)

* Apply suggestions from code review

Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>

* PR fixes

---------

Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>
katcharov added a commit that referenced this pull request Apr 30, 2024
* Implement OIDC SASL mechanism in sync (#1107)

JAVA-4980

* Implement OIDC auth for async (#1131)

JAVA-4981

* Remove non-machine workflow (#1259)

JAVA-5077

* Add Human OIDC Workflow (#1316)

JAVA-5328

* OIDC Add remaining environments (azure, gcp), evergreen testing, API naming updates (#1371)

JAVA-5353
JAVA-5395
JAVA-4834
JAVA-4932

Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants