-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Remove non-machine workflow #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd9c52b
to
ec9887b
Compare
stIncMale
requested changes
Feb 16, 2024
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Show resolved
Hide resolved
driver-core/src/test/resources/auth/legacy/connection-string.json
Outdated
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/RunOnRequirementsMatcher.java
Outdated
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/ErrorMatcher.java
Outdated
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/Entities.java
Outdated
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/Entities.java
Outdated
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/Entities.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java
Show resolved
Hide resolved
Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>
stIncMale
requested changes
Feb 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
stIncMale
approved these changes
Feb 20, 2024
katcharov
added a commit
that referenced
this pull request
Mar 4, 2024
* Remove non-machine workflow * Update prose tests to remove refresh token, principal-request * Conform to latest spec; remove lock around server auth * Rebase fix (async API) * Apply suggestions from code review Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com> * PR fixes --------- Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>
katcharov
added a commit
that referenced
this pull request
Apr 8, 2024
* Remove non-machine workflow * Update prose tests to remove refresh token, principal-request * Conform to latest spec; remove lock around server auth * Rebase fix (async API) * Apply suggestions from code review Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com> * PR fixes --------- Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>
katcharov
added a commit
that referenced
this pull request
Apr 23, 2024
* Remove non-machine workflow * Update prose tests to remove refresh token, principal-request * Conform to latest spec; remove lock around server auth * Rebase fix (async API) * Apply suggestions from code review Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com> * PR fixes --------- Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>
katcharov
added a commit
that referenced
this pull request
Apr 30, 2024
* Implement OIDC SASL mechanism in sync (#1107) JAVA-4980 * Implement OIDC auth for async (#1131) JAVA-4981 * Remove non-machine workflow (#1259) JAVA-5077 * Add Human OIDC Workflow (#1316) JAVA-5328 * OIDC Add remaining environments (azure, gcp), evergreen testing, API naming updates (#1371) JAVA-5353 JAVA-5395 JAVA-4834 JAVA-4932 Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5077
The spec, including unified/prose tests, still requires changes (only code 18 should be detected; some unified tests rely on this and are not implemented). This PR:
Outstanding work: some tests are failing on evergreen (need token directory), but pass locally.