Fix Netty event loop resource leak on MongoClient close. #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAVA-5812
vbabanin
requested review from
a team and
NathanQingyangXu
and removed request for
a team
vbabanin
requested review from
katcharov
and removed request for
NathanQingyangXu
vbabanin
commented
Mar 13, 2025
| public MongoClientImpl(final Cluster cluster, | ||
| final MongoClientSettings settings, | ||
| final MongoDriverInformation mongoDriverInformation, | ||
| @Nullable final AutoCloseable externalResourceCloser) { |
There was a problem hiding this comment.
This change aligns with the implementation in MongoClientImpl for the reactive-streams driver, as detailed here: MongoClientImpl Code.
katcharov
reviewed
Mar 24, 2025
katcharov
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5812