-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Netty benchmark suite. #1647
Conversation
JAVA-5813
JAVA-5813
JAVA-5813
# Conflicts: # driver-benchmarks/build.gradle
JAVA-5813
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just some merge conflicts to fix.
# Conflicts: # driver-benchmarks/src/main/com/mongodb/benchmark/benchmarks/AbstractMongoBenchmark.java # driver-benchmarks/src/main/com/mongodb/benchmark/benchmarks/AbstractWriteBenchmark.java
JAVA-5813
throws Exception { | ||
runBenchmark(new RunCommandBenchmark<>(DOCUMENT_CODEC) | ||
.applyMongoClientSettings(MONGO_CLIENT_SETTINGS)); | ||
runBenchmark(new FindOneBenchmark<Document>("single_and_multi_document/tweet.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only observation is that many other file paths are prefixed with "./"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to ""./" for consistency. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good - do you have a link to and example of it running on evergreen?
JAVA-5813
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vbabanin - LGTM! :)
Depends on #1646 [Merged]
JAVA-5813