Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move CountDocument logic into collection API #4140

Closed
wants to merge 26 commits into from

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Delete CountDocument operation class
  • Move logic into collection.countDocuments
Is there new documentation needed for these changes?

What is the motivation for this change?

The subclass is unneccessary and make typing difficult. See: #4112 (comment)

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Copy link

There is an existing patch(es) for this commit SHA:

Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'.

@nbbeeken nbbeeken added the Blocked Blocked on other work label Jun 10, 2024
@nbbeeken
Copy link
Contributor Author

This should merge to main as a PR separate from the cursor response changes, it currently targets the cursor response PR because it relies on changes in there.

@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 10, 2024
Base automatically changed from NODE-6136-cursor-response to main June 13, 2024 20:45
@nbbeeken nbbeeken closed this Jun 13, 2024
@nbbeeken nbbeeken deleted the chore-migrate-count-doc-operation branch June 13, 2024 20:57
@nbbeeken
Copy link
Contributor Author

#4148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Blocked on other work Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants