Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install solr extension from source #116

Merged
merged 1 commit into from
Sep 12, 2020
Merged

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Sep 12, 2020

Using 2.4.0 release + custom patch (from macports project) seems to
be the only working combination right now. Read the comments in the code
and the links there.

Resolves solr issue in #16, waiting for the upstream as described in #19

This is basically a backport of #58 that was applied
to php72 and up.

The problem with php71 was detected @ moodlehq/moodle-docker#134 (comment)

Using 2.4.0 release + custom patch (from macports project) seems to
be the only working combination right now. Read the comments in the code
and the links there.

Resolves solr issue in moodlehq#16, waiting for the upstream as described in moodlehq#19

This is basically a backport of moodlehq#58 that was applied
to php72 and up.

The problem with php71 was detected @ moodlehq/moodle-docker#134 (comment)
@stronk7
Copy link
Member Author

stronk7 commented Sep 12, 2020

Local tests of the image show it's not passing the solr tests ok:

TESTSUITE: search_solr_testsuite
...
...
>>> startsection Starting phpunit run at Sat Sep 12 12:29:14 CEST 2020 <<<
============================================================================
Moodle 3.5.14 (Build: 20200914), 598064e4d9958b22e8b8c81016440b1aea48771e
Php: 7.1.33, pgsql: 9.6.18, OS: Linux 4.19.76-linuxkit x86_64
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.1.33
Configuration: /var/www/html/phpunit.xml

..............................                                    30 / 30 (100%)

Time: 19.72 seconds, Memory: 80.00MB

OK (30 tests, 238 assertions)

@stronk7 stronk7 merged commit 98be46a into moodlehq:7.1-buster Sep 12, 2020
@stronk7
Copy link
Member Author

stronk7 commented Sep 12, 2020

(self-merged, self-thanks)

@scara
Copy link
Contributor

scara commented Sep 12, 2020

Hi @stronk7,
for the record PHP solr extension 2.5.1 has been recently - 2020-09-09! - released, including the patch proposed in php/pecl-search_engine-solr#16 so we could give 2.5.1 a try and finally close #19 🚀 😎 .

It also includes fixes to run w/ PHP 7.4 and PHP 8.0.0beta03.

HTH,
Matteo

@stronk7
Copy link
Member Author

stronk7 commented Sep 12, 2020

Wow, it was not there a couple of days ago!

I did push the php80beta3 image there then, switching from pecl to pickle and I'm 99% sure I tried.

Let's continue @ #19 , yay! (crossing fingers). Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants