-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install solr extension from source #58
Conversation
Using 2.4.0 release + custom patch (from macports project) seems to be the only working combination right now. Read the comments in the code and the links there. Resolves solr issue in moodlehq#16, waiting for the upstream as described in moodlehq#19
For the records:
Ciao :-) |
(and confirmed that search_solr_engine_testcase continue passing locally) Edited (missed the run information):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really not keen to add yet another script into root/tmp, but I already have a separate issue to get rid fo them all.
They are a really bad thing and against docker's recommendations for building images and we need to get rid of them.
Yeah, I agree. Just thought that it would be easier to continue with the current status/style until we reconsider all the branching/directories/style thing. But agree we should move out from scripts as much as possible (not sure how much that "as much" is, lol). Ciao :-) |
This is basically a backport of moodlehq#58 that was applied to php72 and up. The problem was detected @ moodlehq/moodle-docker#134 (comment)
Using 2.4.0 release + custom patch (from macports project) seems to be the only working combination right now. Read the comments in the code and the links there. Resolves solr issue in moodlehq#16, waiting for the upstream as described in moodlehq#19 This is basically a backport of moodlehq#58 that was applied to php72 and up. The problem with php71 was detected @ moodlehq/moodle-docker#134 (comment)
Using 2.4.0 release + custom patch (from macports project) seems to
be the only working combination right now. Read the comments in the code
and the links there.
Resolves solr issue in #16, waiting for the upstream as described in #19