Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install solr extension from source #58

Merged
merged 2 commits into from
May 23, 2019

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented May 21, 2019

Using 2.4.0 release + custom patch (from macports project) seems to
be the only working combination right now. Read the comments in the code
and the links there.

Resolves solr issue in #16, waiting for the upstream as described in #19

Using 2.4.0 release + custom patch (from macports project) seems to
be the only working combination right now. Read the comments in the code
and the links there.

Resolves solr issue in moodlehq#16, waiting for the upstream as described in moodlehq#19
@stronk7
Copy link
Member Author

stronk7 commented May 21, 2019

For the records:

$ bin/moodle-docker-compose exec webserver vendor/bin/phpunit search_solr_engine_testcase
Moodle 3.8dev (Build: 20190520), a866c5c23866fe527282429384ddbcb902c41c14
Php: 7.2.18, pgsql: 9.6.7, OS: Linux 4.9.125-linuxkit x86_64
PHPUnit 7.5.9 by Sebastian Bergmann and contributors.

.............................                                     29 / 29 (100%)

Time: 32.69 seconds, Memory: 74.50 MB

OK (29 tests, 235 assertions)

Ciao :-)

@stronk7
Copy link
Member Author

stronk7 commented May 22, 2019

(and confirmed that search_solr_engine_testcase continue passing locally)

Edited (missed the run information):

$ bin/moodle-docker-compose exec webserver vendor/bin/phpunit search_solr_engine_testcase
Moodle 3.8dev (Build: 20190520), a866c5c23866fe527282429384ddbcb902c41c14
Php: 7.2.18, pgsql: 9.6.7, OS: Linux 4.9.125-linuxkit x86_64
PHPUnit 7.5.9 by Sebastian Bergmann and contributors.

.............................                                     29 / 29 (100%)

Time: 33.25 seconds, Memory: 74.50 MB

OK (29 tests, 235 assertions)

Copy link
Contributor

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really not keen to add yet another script into root/tmp, but I already have a separate issue to get rid fo them all.

They are a really bad thing and against docker's recommendations for building images and we need to get rid of them.

@andrewnicols andrewnicols merged commit 3cd8b0a into moodlehq:7.2-stretch May 23, 2019
@stronk7 stronk7 deleted the solr72 branch May 23, 2019 08:31
@stronk7
Copy link
Member Author

stronk7 commented May 23, 2019

I'm really not keen to add yet another script into root/tmp, but I already have a separate issue to get rid fo them all.

Yeah, I agree. Just thought that it would be easier to continue with the current status/style until we reconsider all the branching/directories/style thing. But agree we should move out from scripts as much as possible (not sure how much that "as much" is, lol).

Ciao :-)

stronk7 added a commit to stronk7/moodle-php-apache that referenced this pull request Sep 12, 2020
This is basically a backport of moodlehq#58 that was applied
to php72 and up.

The problem was detected @ moodlehq/moodle-docker#134 (comment)
stronk7 pushed a commit to stronk7/moodle-php-apache that referenced this pull request Sep 12, 2020
Using 2.4.0 release + custom patch (from macports project) seems to
be the only working combination right now. Read the comments in the code
and the links there.

Resolves solr issue in moodlehq#16, waiting for the upstream as described in moodlehq#19

This is basically a backport of moodlehq#58 that was applied
to php72 and up.

The problem with php71 was detected @ moodlehq/moodle-docker#134 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants