Add conviction voting Split, SplitAbstain vote options

[4meta5]

Adds precompile method coverage for all possible votes expressible by pallet_conviction::AccountVote:

/// A vote for a referendum of a particular account.
#[derive(Encode, Decode, Copy, Clone, Eq, PartialEq, RuntimeDebug, TypeInfo, MaxEncodedLen)]
pub enum AccountVote<Balance> {
	/// A standard vote, one-way (approve or reject) with a given amount of conviction.
	Standard { vote: Vote, balance: Balance },
	/// A split vote with balances given for both ways, and with no conviction, useful for
	/// parachains when voting.
	Split { aye: Balance, nay: Balance },
	/// A split vote with balances given for both ways as well as abstentions, and with no
	/// conviction, useful for parachains when voting, other off-chain aggregate accounts and
	/// individuals who wish to abstain.
	SplitAbstain { aye: Balance, nay: Balance, abstain: Balance },
}

This PR also makes use of this type inside the conviction voting precompile to simplify the code.

The idea behind SplitAbstain is to vote to end the referendum soon without expressing an opinion on it. substrate PR

[4meta5]

resolved

[tmpolaczyk]

I modifed that test to make the error message less useless:

---- tests::vote_logs_work stdout ----
thread 'tests::vote_logs_work' panicked at 'Expected event not found: RuntimeEvent::Evm(Event::Log { log: Log { address: 0x0000000000000000000000000000000000000001, topics: [0x3839f7832b2a6263aa1fd5040f37d10fd4f9e9c4a9ef07ec384cb1cef9fb4c0e, 0x0000000000000000000000000000000000000000000000000000000000000003], data: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 134, 160, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0] } })
All events:
[RuntimeEvent::Evm(Event::Log { log: Log { address: 0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa, topics: [0x3839f7832b2a6263aa1fd5040f37d10fd4f9e9c4a9ef07ec384cb1cef9fb4c0e, 0x0000000000000000000000000000000000000000000000000000000000000003], data: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 134, 160, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0] } }), RuntimeEvent::Evm(Event::Executed { address: 0x0000000000000000000000000000000000000001 }), RuntimeEvent::Evm(Event::Log { log: Log { address: 0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa, topics: [0x3839f7832b2a6263aa1fd5040f37d10fd4f9e9c4a9ef07ec384cb1cef9fb4c0e, 0x0000000000000000000000000000000000000000000000000000000000000003], data: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 170, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 130, 184, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1] } }), RuntimeEvent::Evm(Event::Executed { address: 0x0000000000000000000000000000000000000001 })]', precompiles/conviction-voting/src/tests.rs:141:17

These are the code changes if you want to include them:

precompiles/conviction-voting/src/tests.rs

// Assert vote events are emitted.
let expected_events = vec![
    EvmEvent::Log {
        log: log2(
            Precompile1,
            SELECTOR_LOG_VOTED,
            H256::from_low_u64_be(ONGOING_POLL_INDEX as u64),
            EvmDataWriter::new()
                .write::<Address>(H160::from(Alice).into()) // caller
                .write::<bool>(true) // vote
                .write::<U256>(100_000.into()) // amount
                .write::<u8>(0) // conviction
                .build(),
        ),
    }
    .into(),
    EvmEvent::Log {
        log: log2(
            Precompile1,
            SELECTOR_LOG_VOTED,
            H256::from_low_u64_be(ONGOING_POLL_INDEX as u64),
            EvmDataWriter::new()
                .write::<Address>(H160::from(Alice).into()) // caller
                .write::<bool>(false) // vote
                .write::<U256>(99_000.into()) // amount
                .write::<u8>(1) // conviction
                .build(),
        ),
    }
    .into(),
];
for log in expected_events {
    assert!(
        events().contains(&log),
        "Expected event not found: {:?}\nAll events:\n{:?}",
        log,
        events()
    );
}