[MOON-2552] fix: only add PoV weight of Self::mint_and_compound() the first time it is called #2459
Conversation
grw-ms
changed the title
Co-authored-by: Alan Sapede <alan.sapede@gmail.com>
|
Coverage generated "Tue Aug 29 12:57:22 UTC 2023": Master coverage: 87.39% |
pallets/parachain-staking/src/lib.rs
Outdated
| // returned will be an over-estimate since the read was already performed on the first | ||
| // call and subsequent calls do not increase PoV size further. | ||
| if already_called_for_delegator { | ||
| actual_weight.set_proof_size(0); |
There was a problem hiding this comment.
Seem's wrong to me as the only overlap is on the storage item DelegationScheduledRequests, it's better to apply x = 0 instead
There was a problem hiding this comment.
This is not going to work.
The way the benchmark is done is that it doesn't properly use the topDelegation storage properly and rely on the DelegationScheduledRequests argument passed, which is already 0 is most of the cases.
If we want to use this method of applying x = 0, then we need to review the weight (around 5kb for x = 0) of the benchmark, as this adds up to 1.5Mb with an empty storage (while in reality a full storage only goes to 150kb)
Co-authored-by: tmpolaczyk <44604217+tmpolaczyk@users.noreply.github.com>
grw-ms
force-pushed
the
grw/moon-2552-empty-blocks-alternate
branch
from
e966e54
to
05226ff
Compare
Co-authored-by: Éloïs <c@elo.tf>
grw-ms
force-pushed
the
grw/moon-2552-empty-blocks-alternate
branch
from
b3133b5
to
173701a
Compare
nbaztec
added
B7-runtimenoteworthy
|
superseded by #2461 |
alternative to #2458
What does it do?
add
already_called_for_delegator: boolargument todelegation_bond_more_without_event()andmint_and_compound, skip adding PoV size if it istrueWhat important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?