Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new benchmark for staking rewards #2461

Merged
merged 12 commits into from
Aug 30, 2023
Merged

Use new benchmark for staking rewards #2461

merged 12 commits into from
Aug 30, 2023

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Aug 29, 2023 •
edited by noandrea
Loading

What does it do?

Uses a simpler benchmark for calculating weight when paying out collator & delegators,
distributing staking rewards no longer has the behavior of producing empty intermittent blocks.
See #2459 for previous work

⚠️ Breaking Changes ⚠️

Change weights for distributing staking rewards

@nbaztec nbaztec added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. breaking Needs to be mentioned in breaking changes labels Aug 29, 2023
@noandrea noandrea mentioned this pull request Aug 29, 2023
Open
28 tasks
@nbaztec nbaztec requested a review from notlesh August 29, 2023 16:29
@noandrea noandrea mentioned this pull request Aug 29, 2023
Closed
@github-actions
Copy link
Contributor

Coverage generated "Wed Aug 30 10:45:44 UTC 2023":
https://d3ifz9vhxc2wtb.cloudfront.net/pulls/2461/html/index.html

Master coverage: 87.39%
Pull coverage:

@nbaztec nbaztec merged commit 356e978 into master Aug 30, 2023
@nbaztec nbaztec deleted the nish-staking-pay-benchmark branch August 30, 2023 12:27
@noandrea noandrea changed the title [MOON-2552] use new benchmark for staking rewards Use new benchmark for staking rewards Aug 31, 2023
@notlesh notlesh removed the D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. label Oct 11, 2023
@notlesh notlesh added the D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@librelois librelois librelois approved these changes

@notlesh notlesh notlesh approved these changes

@crystalin crystalin crystalin approved these changes

Assignees
No one assigned
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nbaztec @crystalin @notlesh @librelois