Enable async backing moonbase #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
approved these changes
Jan 31, 2024
librelois
force-pushed
the
fullly-enable-async-backing-moonbase
branch
from
ac359a1
to
f825459
Compare
This reverts commit eba6d2f.
* timeout * fix * relaxed the test * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR doesn't change the blockspace (block gas limit), so we should expect only 2 time more throughput (because there is 2 times more parablocks).
In theory, async backing also allows collators to have more time to produce the block, so we might be able to increase the CPU time per block in a future PR, but that will involve changing the block gas limit, the pov ratio, the storage growth ratio, which breaks many assumptions and will also require adapting the calculation of dynamic fees...
What important points reviewers should know?
This PR remove some tests for Gov v1, these tests doesn't work anymore because they rely on a per block basis duration for gov v1 stuff, and with this PR all the governance durations are multiplied by 2, but I don't want to loose time to adapt theses tests because Gov v1 was already deprecated and will be removed before the next release.
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?