Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zombienet timeouts for async branch #2644

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

timbrinded
Copy link
Contributor

Increase timeout for test

@timbrinded timbrinded added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Feb 13, 2024
@timbrinded timbrinded changed the title timeout Fix zombienet timeouts for async branch Feb 13, 2024
Copy link
Contributor

github-actions bot commented Feb 13, 2024

Coverage Report

@@                               Coverage Diff                                @@
##           fullly-enable-async-backing-moonbase   timbo-async-fix     +/-   ##
================================================================================
  Coverage                                 80.91%            80.91%   0.00%     
  Files                                       287               287             
- Lines                                     94503             94492     -11     
================================================================================
- Hits                                      76461             76455      -6     
- Misses                                    18042             18037      -5     
Files Changed Coverage
/node/cli/src/cli.rs 34.62% (+0.44%) 🔼
/node/service/src/chain_spec/moonbase.rs 75.22% (-0.14%) 🔽
/node/service/src/chain_spec/moonbeam.rs 10.80% (+0.06%) 🔼
/node/service/src/chain_spec/moonriver.rs 10.80% (+0.06%) 🔼
/runtime/moonbase/tests/common/mod.rs 95.60% (-0.04%) 🔽
/runtime/moonbeam/tests/common/mod.rs 92.40% (-0.06%) 🔽
/runtime/moonriver/tests/common/mod.rs 92.58% (-0.06%) 🔽

Coverage generated Tue Feb 13 17:37:27 UTC 2024

@timbrinded timbrinded marked this pull request as ready for review February 13, 2024 17:54
@librelois librelois merged commit 3f65564 into fullly-enable-async-backing-moonbase Feb 13, 2024
29 checks passed
@librelois librelois deleted the timbo-async-fix branch February 13, 2024 17:57
librelois added a commit that referenced this pull request Feb 14, 2024
* use relay block as clocktime in parachain staking

* add RelayChainBlockNumberProvider trait

* adapt benchmarks

* fix benchmarks

* fix warning in benchmarks

* fix staking TS tests

* upgrade to polkadot v1.3.0

* Temporarily disable kusama and polkadot runtime dependencies

* Remove support for Kusama Native Runtime

* fix delegation tests

* Update evm pin

* update deposit_asset function signature

* change clocktime to a diff of 2

* fix integration tests

* add last_relay_block to can_author runtime api

* fmt and fix some TS tests

* remove default impl for RelayChainBlockNumberProvider and add test comment

* Add Hasher generic parameter to Bounded

* Rename InvalidEvmTransactionError to TransactionValidationError

* Use transfer_allow_death instead of deprecated transfer

* fix build issue

* Use pallet_xcm::RuntimeCall

* BackendReader renamed to Backend in Frontier

* Update frontier pin

* Temporarily update new missing weight functions

* Adapt to new return type of ValidatedTransaction::apply

* IdentityInfo in pallet_identity is now generic

* Associated type Hasher for QueryPreimage, StorePreimage and Bounded

* Update Frontier Pin

* fix runtime compilation errors

* Rename BackendReader to Backend

* Remove Send and Sync Trait Bounds for Frontier Backend

* Implement closest_merkle_tree and child_closest_merkle_tree for StorageProvider

* Set block_relay to none

* Use polkadot_primitives v6

* Annotate EC for Eth::new

* Update polkadot-sdk pin

* Use transferAllowDeath instead of transfer in tests

* start migration

* Update polkadot-sdk pin

* Use transferAllowDeath instead of transfer

* add pre and post checks

* fix typescript test

* add logs for testing

* fix typescript tests

* Fix zombie tests

* finish migration

* clippy

* Fix test balance Transferable

* Temporarily disabled relay-encoder rust tests

* Fix Rust Tests build

* Fix build with runtime-benchmarks

* fmt

* Typescript Fmt

* Set MaxHolds to 1

* comply editorconfig

* fix democracy TS tests

* fix Eslint warning

* Fix typescript test

* fix txpool TS test

* fix precompile identity test

* remove unused import

* Fix rust tests

* Fix rust tests (no reserve anymore with preimage)

* Fix xcm rust tests

* Fix build error

* Update polkadot-sdk pin

* fix collective test

* Add Evm Fix

* use relay slot instead of relay block number

* add TODO in migration

* fix warning

* clippy

* use proper RelayChainSlot type

* fix compilation

* fix types in benchmarks

* new migration logic

* remove parachain_system bound

* add ConsensusHookWrapperForMigration

* remove ConsensusHookWrapper and restore previous migration

* work with the previous round length value

* fix staking TS test

* Fully enable async-backing on moonbase

* adapt GasLimitStorageGrowthRatio to new block gas limit

* make SlotProvider more generic

* minor fixes

* cleanup

* remove unnecessary dependencies

* fix rust compilation

* moonbase rounds are 120 parablocks now

* recompute gas limit pov ratio

* Revert "recompute gas limit pov ratio"

This reverts commit bca701f.

* Revert "adapt GasLimitStorageGrowthRatio to new block gas limit"

This reverts commit c3efa38.

* revert block size changes and min period changes

* revert unneeded tests changes from Agustin's PR

* opengov periods are double in parablocks now

* comment gov v1 tests

* palelt staking should support several "slot times"

* compile rust tests

* remove gov v1 tests

* compile rust tests

* missing import

* try to enable async backing on zombi tests

* inflation info per round are half now

* enable async backing in rpc zombi tests

* force moonbase collators to use async backing

* adapt rust staking tests

* async backing is not optional

* Update pallets/parachain-staking/src/lib.rs

Co-authored-by: Agustín Rodriguez <agus@moonsonglabs.com>

* remove constants no longer used

* fix client compilation

* fmt

* increase capacity and velocity

* use fixed ports for zombi relay

* enable async backing on zombi relay

* add json fields instead of replace

* use a ts script to modify rococo plain specs

* add json fields instead of modify

* use snake case

* use a custom polkadot binary for zombi tests

* update moonkit pin (improve async backing logs)

* not use raw chain spec for rococo

* not call author inherent on_finalize

* Revert "use a custom polkadot binary for zombi tests"

This reverts commit eba6d2f.

* zombinet require plain spec for the relay

* not call AuthorInherent::on_finalize

* no modify rococo specs

* use forked polkadot bins

* properly use forked polkadot bins

* explicitly list all polkadot bins

* fix path location on CI

* Fix zombienet timeouts for async branch (#2644)

* timeout

* fix

* relaxed the test

* lint

* rm broken rust toolchain

* force addition of wasm32 target

---------

Co-authored-by: Agusrodri <agusrodriguez2456@gmail.com>
Co-authored-by: Ahmad Kaouk <ahmadkaouk.93@gmail.com>
Co-authored-by: Agustín Rodriguez <agus@moonsonglabs.com>
Co-authored-by: Tim B <79199034+timbrinded@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants