fix unimplementable prioritization #563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluffy
added
the
Needs Discussion
suhasHere
approved these changes
Oct 1, 2024
ianswett
reviewed
Oct 4, 2024
| @@ -627,7 +627,7 @@ implementation-dependent, but the expectation is that all subscriptions will | |||
| be able to send some data. | |||
|
|
|||
| The subscriber's priority can be changed via a SUBSCRIBE_UPDATE message. | |||
| This updates the priority of all unsent data within the subscription, | |||
| This updates the priority of future data within the subscription, | |||
There was a problem hiding this comment.
What about just all data in the subscription? Technically, if data is sent, then lost, when you retransmit it you might want to use the updated subscription priority, for example.
Suggested change
| This updates the priority of future data within the subscription, | |
| This updates the priority of all data within the subscription, |
There was a problem hiding this comment.
yah, I'm not sure best wording. If the data has already been passed to QUIC stack, probably very hard to change the priority of the data. I'm think we need words that might be a bit vague here. It seems data published by original publisher after the priority change clearly need to be handled at new priority but stuff that was inflight when the change was made may or may not get the new priority.
|
This section was entirely rewritten in #518 , so I think this PR is OBE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a case where the relay has passed the UDP packet to the linux kernel but the kernel has not sent it yet and then the priorities are changed. There is no way to get the priority for the data that already in the send Q.