Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unimplementable prioritization #563

Closed
wants to merge 1 commit into from
+1 −1
Closed

fix unimplementable prioritization #563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion draft-ietf-moq-transport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ implementation-dependent, but the expectation is that all subscriptions will
be able to send some data.

The subscriber's priority can be changed via a SUBSCRIBE_UPDATE message.
This updates the priority of all unsent data within the subscription,
This updates the priority of future data within the subscription,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about just all data in the subscription? Technically, if data is sent, then lost, when you retransmit it you might want to use the updated subscription priority, for example.

Suggested change
This updates the priority of future data within the subscription,
This updates the priority of all data within the subscription,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah, I'm not sure best wording. If the data has already been passed to QUIC stack, probably very hard to change the priority of the data. I'm think we need words that might be a bit vague here. It seems data published by original publisher after the priority change clearly need to be handled at new priority but stuff that was inflight when the change was made may or may not get the new priority.

though the details of the reprioritization are implementation-specific.

Subscriptions have a Group Order of either 'Ascending' or 'Descending',
Expand Down
Loading