-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify multiple transport streams for Subgroups #642
base: main
Are you sure you want to change the base?
Conversation
Clarify the case for multiple QUIC streams in the Subgroups intro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, I made a couple minor suggestions.
Co-authored-by: afrind <afrind@users.noreply.github.com>
The rest of that section was full of references to QUIC as well, so I cleaned those up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, or we could say just 'stream' instead of 'transport stream' in some places.
have a dependency and priority relationship consistent with sharing a transport | ||
stream. A Group will be delivered using at least as many transport streams as | ||
there are Subgroups, typically with a one-to-one mapping between Subgroups | ||
and streams. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make it more stronger saying "There is one to one mapping between Subgroups and Streams"
|
||
When a Track's forwarding preference (see {{object-fields}}) is "Track" or | ||
"Datagram", Objects are not sent in Subgroups, no Subgroup IDs are assigned, and the | ||
description in the remainder of this section does not apply. | ||
|
||
QUIC streams offer in-order reliable delivery and the ability to cancel sending | ||
QUIC and WebTransport streams offer in-order reliable delivery and the ability to cancel sending |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder why we need to add the additional qualifier for WebTransport?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do see the intent on keeping the stream bit abstract. However, I wonder making it explicit, as QUIC Stream, was the right intent though
Clarify the case for multiple QUIC streams in the Subgroups intro. The current version reading "some cases" makes the use of multiple streams sound infrequent, and the relationship isn't made clear until a few paragraphs later.