-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify multiple transport streams for Subgroups #642
Open
ac-freeman
wants to merge
4
commits into
moq-wg:main
Choose a base branch
from
ac-freeman:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -329,34 +329,35 @@ Objects within a group are ordered numerically by their Object ID. | |
A subgroup is a sequence of one or more objects from the same group | ||
({{model-group}}) in ascending order by Object ID. Objects in a subgroup | ||
have a dependency and priority relationship consistent with sharing a QUIC | ||
stream. In some cases, a Group will be most effectively delivered using more | ||
than one QUIC stream. | ||
stream. A Group will be delivered using at least as many transport streams as | ||
there are Subgroups, typically with a one-to-one mapping between Subgroups | ||
and streams. | ||
|
||
When a Track's forwarding preference (see {{object-fields}}) is "Track" or | ||
"Datagram", Objects are not sent in Subgroups, no Subgroup IDs are assigned, and the | ||
description in the remainder of this section does not apply. | ||
|
||
QUIC streams offer in-order reliable delivery and the ability to cancel sending | ||
QUIC and WebTransport streams offer in-order reliable delivery and the ability to cancel sending | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wonder why we need to add the additional qualifier for WebTransport? |
||
and retransmission of data. Furthermore, many implementations offer the ability | ||
to control the relative priority of streams, which allows control over the | ||
scheduling of sending data on active streams. | ||
|
||
Every object within a Group belongs to exactly one Subgroup. | ||
|
||
Objects from two subgroups cannot be sent on the same QUIC stream. Objects from the | ||
same Subgroup MUST NOT be sent on different QUIC streams, unless one of the streams | ||
Objects from two subgroups cannot be sent on the same transport stream. Objects from the | ||
same Subgroup MUST NOT be sent on different transport streams, unless one of the streams | ||
was reset prematurely, or upstream conditions have forced objects from a Subgroup | ||
to be sent out of Object ID order. | ||
|
||
Original publishers assign each Subgroup a Subgroup ID, and do so as they see fit. The | ||
scope of a Subgroup ID is a Group, so Subgroups from different Groups MAY share a Subgroup | ||
ID without implying any relationship between them. In general, publishers assign | ||
objects to subgroups in order to leverage the features of QUIC streams as described | ||
objects to subgroups in order to leverage the features of transport streams as described | ||
above. | ||
|
||
An example strategy for using QUIC stream properties follows. If object B is | ||
An example strategy for using transport stream properties follows. If object B is | ||
dependent on object A, then delivery of B can follow A, i.e. A and B can be | ||
usefully delivered over a single QUIC stream. Furthermore, in this example: | ||
usefully delivered over a single transport stream. Furthermore, in this example: | ||
|
||
- If an object is dependent on all previous objects in a Subgroup, it is added to | ||
that Subgroup. | ||
|
@@ -366,7 +367,7 @@ a different Subgroup. | |
|
||
- There are often many ways to compose Subgroups that meet these criteria. Where | ||
possible, choose the composition that results in the fewest Subgroups in a group | ||
to minimize the number of QUIC streams used. | ||
to minimize the number of transport streams used. | ||
|
||
|
||
## Groups {#model-group} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make it more stronger saying "There is one to one mapping between Subgroups and Streams"