Skip to content

Conversation

chfw
Copy link
Member

@chfw chfw commented Dec 1, 2019

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

chfw added 3 commits November 14, 2019 20:16
test github actions
…warning+info+debug (#350)

* 👕 no verbose for error,  -v for warning, -vv for warning+info, -vvv for warning+info+debug

* 📚 update change log

* 💄 pump up version number

* 🔥 remove unused imports

* 👕 update work flow yaml which blocks the ci build

* 🔥 remove corresponding test on python 2.7 3.5 on github actions

* 💚 update unit tests

* 📚 update change log

* 🔬 one more test case
* ✨ Copy engine to have 'Copying'.

* ✨ add jinja2 template action and past tense verb

* 💚 update unit tests

* 📚 update documentation

* 📚 update docs

* 🔨 code refactoring

* 📚 update change log

* ✨ prepare for 0.6.7 release
@codecov-io
Copy link

codecov-io commented Dec 1, 2019

Codecov Report

Merging #353 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #353      +/-   ##
=========================================
+ Coverage   96.24%   96.3%   +0.05%     
=========================================
  Files          55      55              
  Lines        2795    2812      +17     
=========================================
+ Hits         2690    2708      +18     
+ Misses        105     104       -1
Impacted Files Coverage Δ
moban/plugins/jinja2/engine.py 100% <100%> (ø) ⬆️
moban/core/context.py 100% <100%> (ø) ⬆️
moban/_version.py 100% <100%> (ø) ⬆️
moban/main.py 100% <100%> (+0.71%) ⬆️
moban/core/moban_factory.py 98.07% <100%> (+0.02%) ⬆️
moban/plugins/copy.py 100% <100%> (ø) ⬆️
...sts/integration_tests/test_command_line_options.py 99.7% <100%> (ø) ⬆️
moban/externals/reporter.py 95.91% <100%> (-0.24%) ⬇️
tests/test_reporter.py 100% <100%> (ø) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e456f2a...f043fb7. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Dec 1, 2019

Codecov Report

Merging #353 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #353      +/-   ##
=========================================
+ Coverage   96.24%   96.3%   +0.05%     
=========================================
  Files          55      55              
  Lines        2795    2812      +17     
=========================================
+ Hits         2690    2708      +18     
+ Misses        105     104       -1
Impacted Files Coverage Δ
moban/plugins/jinja2/engine.py 100% <100%> (ø) ⬆️
moban/core/context.py 100% <100%> (ø) ⬆️
moban/_version.py 100% <100%> (ø) ⬆️
moban/main.py 100% <100%> (+0.71%) ⬆️
moban/core/moban_factory.py 98.07% <100%> (+0.02%) ⬆️
moban/plugins/copy.py 100% <100%> (ø) ⬆️
...sts/integration_tests/test_command_line_options.py 99.7% <100%> (ø) ⬆️
moban/externals/reporter.py 95.91% <100%> (-0.24%) ⬇️
tests/test_reporter.py 100% <100%> (ø) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e456f2a...f043fb7. Read the comment docs.

@chfw chfw merged commit 65bfc7e into master Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants