Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacement-pairs fail at end of word #91

Closed
danielnaber opened this issue Jul 14, 2017 · 3 comments
Closed

replacement-pairs fail at end of word #91

danielnaber opened this issue Jul 14, 2017 · 3 comments
Labels
Milestone

Comments

@danielnaber
Copy link
Collaborator

It seems replacement pairs, at least when of different length, fail at the end of a word. E.g. "Fux" doesn't suggest "Fuchs" even with fsa.dict.speller.replacement-pairs=x chs. Adding two more characters at the end of the word makes it work (i.e. Fuxee suggests Fuchsee, both are fantasy words).

I've added a stand-alone example here in LanguageTool: https://github.com/languagetool-org/languagetool/blob/6d38df7eda58bfc6b796d91e35fc7debda57f7d5/languagetool-language-modules/de/src/test/java/org/languagetool/rules/de/GermanSpellerRuleTest.java#L369

Maybe this is related to this comment. If this is actually a bug and won't be fixed, it should be documented.

@jaumeortola
Copy link
Contributor

It is probably related to the previous bug you mention. I will take a look, but I foresee it will be difficult to fix.

jaumeortola added a commit to jaumeortola/morfologik-stemming that referenced this issue Jul 15, 2017
@jaumeortola
Copy link
Contributor

This fixes the problem. There is no reason not to try replacements in short words.

@dweiss dweiss closed this as completed Jul 31, 2017
@dweiss
Copy link
Member

dweiss commented Jul 31, 2017

(Released the fix in 2.1.4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants