IRM refactor

foundry.toml

@@ -7,6 +7,9 @@ libs = ["lib"]
 [profile.default.fuzz]
 runs = 4096
 
+[profile.default.invariant]
+fail_on_revert = true
+
 [profile.default.fmt]
 wrap_comments = true
 
@@ -20,5 +23,13 @@ script = "/dev/null"
 [profile.test]
 via-ir = false
 
+[profile.test.fuzz]
+runs = 16384
+
+[profile.test.invariant]
+runs = 32
+depth = 1024
+fail_on_revert = true
+
 
 # See more config options https://github.com/foundry-rs/foundry/blob/master/crates/config/README.md#all-options

src/SpeedJumpIrm.sol

@@ -3,93 +3,92 @@ pragma solidity 0.8.19;
 
 import {IIrm} from "../lib/morpho-blue/src/interfaces/IIrm.sol";
 
-import {MathLib} from "./libraries/MathLib.sol";
 import {UtilsLib} from "./libraries/UtilsLib.sol";
 import {ErrorsLib} from "./libraries/ErrorsLib.sol";
+import {MathLib, WAD_INT as WAD} from "./libraries/MathLib.sol";
 import {MarketParamsLib} from "../lib/morpho-blue/src/libraries/MarketParamsLib.sol";
 import {Id, MarketParams, Market} from "../lib/morpho-blue/src/interfaces/IMorpho.sol";
-import {WAD, MathLib as MorphoMathLib} from "../lib/morpho-blue/src/libraries/MathLib.sol";
+import {MathLib as MorphoMathLib} from "../lib/morpho-blue/src/libraries/MathLib.sol";
 
-struct MarketIrm {
-    // Previous final borrow rate. Scaled by WAD.
-    uint128 prevBorrowRate;
-    // Previous error. Scaled by WAD.
-    int128 prevErr;
-}
-
-/// @title SpeedJumpIrm
+/// @title AdaptativeCurveIrm
 /// @author Morpho Labs
 /// @custom:contact security@morpho.org
-/// @notice Interest rate model.
-contract SpeedJumpIrm is IIrm {
+contract AdaptativeCurveIrm is IIrm {
     using MathLib for int256;
-    using MathLib for uint256;
-    using UtilsLib for uint256;
+    using UtilsLib for int256;
     using MorphoMathLib for uint128;
     using MorphoMathLib for uint256;
     using MarketParamsLib for MarketParams;
 
     /* EVENTS */
 
     /// @notice Emitted when a borrow rate is updated.
-    event BorrowRateUpdate(Id indexed id, int128 err, uint128 newBorrowRate, uint256 avgBorrowRate);
+    event BorrowRateUpdate(Id indexed id, uint256 avgBorrowRate, uint256 rateAtTarget);
 
     /* CONSTANTS */
 
-    /// @notice Maximum rate per second (scaled by WAD) (1B% APR).
-    uint256 public constant MAX_RATE = uint256(1e7 ether) / 365 days;
-    /// @notice Mininimum rate per second (scaled by WAD) (0.1% APR).
-    uint256 public constant MIN_RATE = uint256(0.001 ether) / 365 days;
+    /// @notice Maximum rate at target per second (scaled by WAD) (1B% APR).
+    int256 public constant MAX_RATE_AT_TARGET = int256(0.01e9 ether) / 365 days;
+    /// @notice Mininimum rate at target per second (scaled by WAD) (0.1% APR).
+    int256 public constant MIN_RATE_AT_TARGET = int256(0.001 ether) / 365 days;
     /// @notice Address of Morpho.
     address public immutable MORPHO;
-    /// @notice Ln of the jump factor (scaled by WAD).
-    uint256 public immutable LN_JUMP_FACTOR;
-    /// @notice Speed factor (scaled by WAD).
-    /// @dev The speed is per second, so the rate moves at a speed of SPEED_FACTOR * err each second (while being
-    /// continuously compounded). A typical value for the SPEED_FACTOR would be 10 ethers / 365 days.
-    uint256 public immutable SPEED_FACTOR;
+    /// @notice Curve steepness (scaled by WAD).
+    /// @dev Verified to be greater than 1 at construction.
+    int256 public immutable CURVE_STEEPNESS;
+    /// @notice Adjustment speed (scaled by WAD).
+    /// @dev The speed is per second, so the rate moves at a speed of ADJUSTMENT_SPEED * err each second (while being
+    /// continuously compounded). A typical value for the ADJUSTMENT_SPEED would be 10 ethers / 365 days.
+    /// @dev Verified to be non-negative at construction.
+    int256 public immutable ADJUSTMENT_SPEED;
     /// @notice Target utilization (scaled by WAD).
-    uint256 public immutable TARGET_UTILIZATION;
-    /// @notice Initial rate (scaled by WAD).
-    uint128 public immutable INITIAL_RATE;
+    /// @dev Verified to be strictly between 0 and 1 at construction.
+    int256 public immutable TARGET_UTILIZATION;
+    /// @notice Initial rate at target per second (scaled by WAD).
+    /// @dev Verified to be between MIN_RATE_AT_TARGET and MAX_RATE_AT_TARGET at contruction.
+    int256 public immutable INITIAL_RATE_AT_TARGET;
 
     /* STORAGE */
 
-    /// @notice IRM storage for each market.
-    mapping(Id => MarketIrm) public marketIrm;
+    /// @notice Rate at target utilization.
+    /// @dev Tells the height of the curve.
+    mapping(Id => int256) public rateAtTarget;
 
     /* CONSTRUCTOR */
 
     /// @notice Constructor.
     /// @param morpho The address of Morpho.
-    /// @param lnJumpFactor The log of the jump factor (scaled by WAD).
-    /// @param speedFactor The speed factor (scaled by WAD).
-    /// @param targetUtilization The target utilization (scaled by WAD). Should be strictly between 0 and 1.
-    /// @param initialRate The initial rate (scaled by WAD).
+    /// @param curveSteepness The curve steepness (scaled by WAD).
+    /// @param adjustmentSpeed The adjustment speed (scaled by WAD).
+    /// @param targetUtilization The target utilization (scaled by WAD).
+    /// @param initialRateAtTarget The initial rate at target (scaled by WAD).
     constructor(
         address morpho,
-        uint256 lnJumpFactor,
-        uint256 speedFactor,
-        uint256 targetUtilization,
-        uint128 initialRate
+        int256 curveSteepness,
+        int256 adjustmentSpeed,
+        int256 targetUtilization,
+        int256 initialRateAtTarget
     ) {
-        require(lnJumpFactor <= uint256(type(int256).max), ErrorsLib.INPUT_TOO_LARGE);
-        require(speedFactor <= uint256(type(int256).max), ErrorsLib.INPUT_TOO_LARGE);
+        require(morpho != address(0), ErrorsLib.ZERO_ADDRESS);
+        require(curveSteepness >= WAD, ErrorsLib.INPUT_TOO_SMALL);
+        require(adjustmentSpeed >= 0, ErrorsLib.INPUT_TOO_SMALL);
         require(targetUtilization < WAD, ErrorsLib.INPUT_TOO_LARGE);
         require(targetUtilization > 0, ErrorsLib.ZERO_INPUT);
+        require(initialRateAtTarget >= MIN_RATE_AT_TARGET, ErrorsLib.INPUT_TOO_SMALL);
+        require(initialRateAtTarget <= MAX_RATE_AT_TARGET, ErrorsLib.INPUT_TOO_LARGE);
 
         MORPHO = morpho;
-        LN_JUMP_FACTOR = lnJumpFactor;
-        SPEED_FACTOR = speedFactor;
+        CURVE_STEEPNESS = curveSteepness;
+        ADJUSTMENT_SPEED = adjustmentSpeed;
         TARGET_UTILIZATION = targetUtilization;
-        INITIAL_RATE = initialRate;
+        INITIAL_RATE_AT_TARGET = initialRateAtTarget;
     }
 
     /* BORROW RATES */
 
     /// @inheritdoc IIrm
     function borrowRateView(MarketParams memory marketParams, Market memory market) external view returns (uint256) {
-        (,, uint256 avgBorrowRate) = _borrowRate(marketParams.id(), market);
+        (uint256 avgBorrowRate,) = _borrowRate(marketParams.id(), market);
         return avgBorrowRate;
     }
 
@@ -99,57 +98,76 @@ contract SpeedJumpIrm is IIrm {
 
         Id id = marketParams.id();
 
-        (int128 err, uint128 newBorrowRate, uint256 avgBorrowRate) = _borrowRate(id, market);
+        (uint256 avgBorrowRate, int256 endRateAtTarget) = _borrowRate(id, market);
 
-        marketIrm[id].prevErr = err;
-        marketIrm[id].prevBorrowRate = newBorrowRate;
+        rateAtTarget[id] = endRateAtTarget;
 
-        emit BorrowRateUpdate(id, err, newBorrowRate, avgBorrowRate);
+        // Safe "unchecked" because endRateAtTarget >= 0.
+        emit BorrowRateUpdate(id, avgBorrowRate, uint256(endRateAtTarget));
 
         return avgBorrowRate;
     }
 
-    /// @dev Returns err, newBorrowRate and avgBorrowRate.
-    function _borrowRate(Id id, Market memory market) private view returns (int128, uint128, uint128) {
-        uint256 utilization =
-            market.totalSupplyAssets > 0 ? market.totalBorrowAssets.wDivDown(market.totalSupplyAssets) : 0;
-
-        uint256 errNormFactor = utilization > TARGET_UTILIZATION ? WAD - TARGET_UTILIZATION : TARGET_UTILIZATION;
-        // Safe "unchecked" int128 cast because |err| <= WAD.
-        // Safe "unchecked" int256 casts because utilization <= WAD, TARGET_UTILIZATION < WAD and errNormFactor <= WAD.
-        int128 err = int128((int256(utilization) - int256(TARGET_UTILIZATION)).wDivDown(int256(errNormFactor)));
-
-        MarketIrm storage irm = marketIrm[id];
-        if (irm.prevBorrowRate == 0) return (err, INITIAL_RATE, INITIAL_RATE);
-
-        // errDelta = err - prevErr.
-        // errDelta is between -1 and 1, scaled by WAD.
-        int256 errDelta = err - irm.prevErr;
-
-        // Safe "unchecked" cast because LN_JUMP_FACTOR <= type(int256).max.
-        uint256 jumpMultiplier = MathLib.wExp(errDelta.wMulDown(int256(LN_JUMP_FACTOR)));
-        // Safe "unchecked" cast because SPEED_FACTOR <= type(int256).max.
-        int256 speed = int256(SPEED_FACTOR).wMulDown(err);
-        uint256 elapsed = block.timestamp - market.lastUpdate;
-        // Safe "unchecked" cast because elapsed <= block.timestamp.
-        int256 linearVariation = speed * int256(elapsed);
-        uint256 variationMultiplier = MathLib.wExp(linearVariation);
-
-        // newBorrowRate = prevBorrowRate * jumpMultiplier * variationMultiplier.
-        uint256 borrowRateAfterJump = irm.prevBorrowRate.wMulDown(jumpMultiplier);
-        uint256 newBorrowRate = borrowRateAfterJump.wMulDown(variationMultiplier);
-
-        // Then we compute the average rate over the period (this is what Morpho needs to accrue the interest).
-        // avgBorrowRate = 1 / elapsed * ∫ borrowRateAfterJump * exp(speed * t) dt between 0 and elapsed
-        //               = borrowRateAfterJump * (exp(linearVariation) - 1) / linearVariation
-        //               = (newBorrowRate - borrowRateAfterJump) / linearVariation
-        // And avgBorrowRate ~ borrowRateAfterJump for linearVariation around zero.
-        uint256 avgBorrowRate;
-        if (linearVariation == 0) avgBorrowRate = borrowRateAfterJump;
-        // Safe "unchecked" cast to uint256 because linearVariation < 0 <=> newBorrowRate <= borrowRateAfterJump.
-        else avgBorrowRate = uint256((int256(newBorrowRate) - int256(borrowRateAfterJump)).wDivDown(linearVariation));
-
-        // We bound both newBorrowRate and avgBorrowRate between MIN_RATE and MAX_RATE.
-        return (err, uint128(newBorrowRate.bound(MIN_RATE, MAX_RATE)), uint128(avgBorrowRate.bound(MIN_RATE, MAX_RATE)));
+    /// @dev Returns avgBorrowRate and endRateAtTarget.
+    /// @dev Assumes that the inputs `marketParams` and `id` match.
+    function _borrowRate(Id id, Market memory market) private view returns (uint256, int256) {
+        // Safe "unchecked" cast because the utilization is smaller than 1 (scaled by WAD).
+        int256 utilization =
+            int256(market.totalSupplyAssets > 0 ? market.totalBorrowAssets.wDivDown(market.totalSupplyAssets) : 0);
+
+        int256 errNormFactor = utilization > TARGET_UTILIZATION ? WAD - TARGET_UTILIZATION : TARGET_UTILIZATION;
+        int256 err = (utilization - TARGET_UTILIZATION).wDivDown(errNormFactor);
+
+        int256 startRateAtTarget = rateAtTarget[id];
+
+        // First interaction.
+        if (startRateAtTarget == 0) {
+            return (uint256(_curve(INITIAL_RATE_AT_TARGET, err)), INITIAL_RATE_AT_TARGET);
+        } else {
+            // Note that the speed is assumed constant between two interactions, but in theory it increases because of
+            // interests. So the rate will be slightly underestimated.
+            int256 speed = ADJUSTMENT_SPEED.wMulDown(err);
+
+            // market.lastUpdate != 0 because it is not the first interaction with this market.
+            // Safe "unchecked" cast because block.timestamp - market.lastUpdate <= block.timestamp <= type(int256).max.
+            int256 elapsed = int256(block.timestamp - market.lastUpdate);
+            int256 linearAdaptation = speed * elapsed;
+            int256 adaptationMultiplier = MathLib.wExp(linearAdaptation);
+            // endRateAtTarget is bounded between MIN_RATE_AT_TARGET and MAX_RATE_AT_TARGET.
+            int256 endRateAtTarget =
+                startRateAtTarget.wMulDown(adaptationMultiplier).bound(MIN_RATE_AT_TARGET, MAX_RATE_AT_TARGET);
+            int256 endBorrowRate = _curve(endRateAtTarget, err);
+
+            // Then we compute the average rate over the period.
+            // Note that startBorrowRate is defined in the computations below.
+            // avgBorrowRate = 1 / elapsed * ∫ startBorrowRate * exp(speed * t) dt between 0 and elapsed
+            //               = startBorrowRate * (exp(linearAdaptation) - 1) / linearAdaptation
+            //               = (endBorrowRate - startBorrowRate) / linearAdaptation
+            // And for linearAdaptation around zero: avgBorrowRate ~ startBorrowRate = endBorrowRate.
+            // Also, when it is the first interaction (rateAtTarget = 0).
+            int256 avgBorrowRate;
+            if (linearAdaptation == 0) {
+                avgBorrowRate = endBorrowRate;
+            } else {
+                int256 startBorrowRate = _curve(startRateAtTarget, err);
+                avgBorrowRate = (endBorrowRate - startBorrowRate).wDivDown(linearAdaptation);
+            }
+
+            // avgBorrowRate is non negative because:
+            // - endBorrowRate >= 0 because endRateAtTarget >= MIN_RATE_AT_TARGET.
+            // - linearAdaptation < 0 <=> adaptationMultiplier <= 1 <=> endBorrowRate <= startBorrowRate.
+            return (uint256(avgBorrowRate), endRateAtTarget);
+        }
+    }
+
+    /// @dev Returns the rate for a given `_rateAtTarget` and an `err`.
+    /// The formula of the curve is the following:
+    /// r = ((1-1/C)*err + 1) * rateAtTarget if err < 0
+    ///     ((C-1)*err + 1) * rateAtTarget else.
+    function _curve(int256 _rateAtTarget, int256 err) private view returns (int256) {
+        // Non negative because 1 - 1/C >= 0, C - 1 >= 0.
+        int256 coeff = err < 0 ? WAD - WAD.wDivDown(CURVE_STEEPNESS) : CURVE_STEEPNESS - WAD;
+        // Non negative because if err < 0, coeff <= 1.
+        return (coeff.wMulDown(err) + WAD).wMulDown(int256(_rateAtTarget));
     }
 }

src/libraries/ErrorsLib.sol

@@ -9,14 +9,14 @@ library ErrorsLib {
     /// @dev Thrown when the input is too large to fit in the expected type.
     string internal constant INPUT_TOO_LARGE = "input too large";
 
-    /// @dev Thrown when passing the zero input.
-    string internal constant ZERO_INPUT = "zero input";
+    /// @dev Thrown when the input is too small.
+    string internal constant INPUT_TOO_SMALL = "input too small";
 
-    /// @dev Thrown when wExp underflows.
-    string internal constant WEXP_UNDERFLOW = "wExp underflow";
+    /// @dev Thrown when passing the zero address.
+    string internal constant ZERO_ADDRESS = "zero address";
 
-    /// @dev Thrown when wExp overflows.
-    string internal constant WEXP_OVERFLOW = "wExp overflow";
+    /// @dev Thrown when passing the zero input.
+    string internal constant ZERO_INPUT = "zero input";
 
     /// @dev Thrown when the caller is not Morpho.
     string internal constant NOT_MORPHO = "not Morpho";

src/libraries/MathLib.sol

@@ -1,7 +1,6 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 
-import {ErrorsLib} from "./ErrorsLib.sol";
 import {WAD} from "../../lib/morpho-blue/src/libraries/MathLib.sol";
 
 int256 constant WAD_INT = int256(WAD);
@@ -14,30 +13,39 @@ library MathLib {
     using MathLib for uint128;
     using MathLib for uint256;
     using {wDivDown} for int256;
-    using {wMulDown} for int256;
 
     /// @dev ln(2).
-    int256 private constant LN2_INT = 0.693147180559945309 ether;
+    int256 internal constant LN_2_INT = 0.693147180559945309 ether;
+
+    /// @dev ln(1e-18).
+    int256 internal constant LN_WEI_INT = -41.446531673892822312 ether;
+
+    /// @dev Above this bound, `wExp` is clipped to avoid overflowing when multiplied with 1 ether.
+    /// @dev This upper bound corresponds to: ln(type(int256).max / 1e36) (scaled by WAD, floored).
+    int256 internal constant WEXP_UPPER_BOUND = 93.859467695000404319 ether;
+
+    /// @dev The value of wExp(`WEXP_UPPER_BOUND`).
+    int256 internal constant WEXP_UPPER_VALUE = 57716089161558943862588783571184261698504.523000224082296832 ether;
 
     /// @dev Returns an approximation of exp.
-    function wExp(int256 x) internal pure returns (uint256) {
+    function wExp(int256 x) internal pure returns (int256) {
         unchecked {
-            // Revert if x > ln(2^256-1) ~ 177.
-            require(x <= 177.44567822334599921 ether, ErrorsLib.WEXP_OVERFLOW);
-            // Revert if x < -(2**255-1) + (ln(2)/2).
-            require(x >= type(int256).min + LN2_INT / 2, ErrorsLib.WEXP_UNDERFLOW);
+            // If x < ln(1e-18) then exp(x) < 1e-18 so it is rounded to zero.
+            if (x < LN_WEI_INT) return 0;
+            // `wExp` is clipped to avoid overflowing when multiplied with 1 ether.
+            if (x >= WEXP_UPPER_BOUND) return WEXP_UPPER_VALUE;
 
             // Decompose x as x = q * ln(2) + r with q an integer and -ln(2)/2 <= r <= ln(2)/2.
             // q = x / ln(2) rounded half toward zero.
-            int256 roundingAdjustment = (x < 0) ? -(LN2_INT / 2) : (LN2_INT / 2);
+            int256 roundingAdjustment = (x < 0) ? -(LN_2_INT / 2) : (LN_2_INT / 2);
             // Safe unchecked because x is bounded.
-            int256 q = (x + roundingAdjustment) / LN2_INT;
-            // Safe unchecked because |q * LN2_INT| <= |x|.
-            int256 r = x - q * LN2_INT;
+            int256 q = (x + roundingAdjustment) / LN_2_INT;
+            // Safe unchecked because |q * ln(2) - x| <= ln(2)/2.
+            int256 r = x - q * LN_2_INT;
 
             // Compute e^r with a 2nd-order Taylor polynomial.
-            // Safe unchecked because |r| < 1, expR < 2 and the sum is positive.
-            uint256 expR = uint256(WAD_INT + r + r.wMulDown(r) / 2);
+            // Safe unchecked because |r| < 1e18.
+            int256 expR = WAD_INT + r + (r * r) / WAD_INT / 2;
 
             // Return e^x = 2^q * e^r.
             if (q >= 0) return expR << uint256(q);

src/libraries/UtilsLib.sol

@@ -8,12 +8,12 @@ pragma solidity ^0.8.0;
 library UtilsLib {
     /// @dev Bounds `x` between `low` and `high`.
     /// @dev Assumes that `low` <= `high`. If it is not the case it returns `low`.
-    function bound(uint256 x, uint256 low, uint256 high) internal pure returns (uint256 z) {
+    function bound(int256 x, int256 low, int256 high) internal pure returns (int256 z) {
         assembly {
             // z = min(x, high).
-            z := xor(x, mul(xor(x, high), lt(high, x)))
+            z := xor(x, mul(xor(x, high), slt(high, x)))
             // z = max(z, low).
-            z := xor(z, mul(xor(z, low), gt(low, z)))
+            z := xor(z, mul(xor(z, low), sgt(low, z)))
         }
     }
 }