IRM refactor #54
Merged
IRM refactor #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
reviewed
Oct 27, 2023
MathisGD
requested review from
a team,
Rubilmax,
MerlinEgalite,
Jean-Grimal and
QGarchery
and removed request for
a team
MathisGD
force-pushed
the
refactor/curve
branch
from
a451e40
to
4dab1c8
Compare
MathisGD
force-pushed
the
refactor/curve
branch
from
4dab1c8
to
e061946
Compare
MerlinEgalite
requested changes
Oct 31, 2023
…tion-zero return early linear adaptation zero
little refactoring proposal
More concise comments for trapeze N=2
Trapezoidal (n=2)
Riemann average
MerlinEgalite
dismissed stale reviews from Jean-Grimal and themself
via
4637e31
MathisGD
requested review from
Rubilmax,
QGarchery,
MerlinEgalite and
julien-devatom
MerlinEgalite
approved these changes
Nov 16, 2023
QGarchery
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new abstraction of the IRM, with a moving rate curve.
Fixes notably #42, #55, https://github.com/cantinasec/review-morpho-blue-1/issues/37, https://github.com/cantinasec/review-morpho-blue-1/issues/36, https://github.com/cantinasec/review-morpho-blue-1/issues/35