Riemann average #82
Merged
Riemann average #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
reviewed
Nov 15, 2023
QGarchery
reviewed
Nov 15, 2023
QGarchery
reviewed
Nov 15, 2023
MerlinEgalite
requested review from
Rubilmax,
MerlinEgalite,
QGarchery and
Jean-Grimal
QGarchery
requested changes
Nov 16, 2023
peyha
reviewed
Nov 16, 2023
MattLsb
reviewed
Nov 16, 2023
…tion-zero return early linear adaptation zero
This comment was marked as resolved.
This comment was marked as resolved.
MerlinEgalite
approved these changes
Nov 16, 2023
QGarchery
approved these changes
Nov 16, 2023
little refactoring proposal
More concise comments for trapeze N=2
Trapezoidal (n=2)
Rubilmax
approved these changes
Nov 16, 2023
MerlinEgalite
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Uses Riemann sum to compute the integral (average) of the rate over the period. This method is much more robust than the previous analytical one.
The maths are written in the code directly.
Fixes:
Gas diff with
refactor/curve