Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log all extraneous_keys in one go for ease of development #1344

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

josejg
Copy link
Contributor

@josejg josejg commented Jul 9, 2024

In the spirit of productivity, I think it'd be good for foundry to specify all extraneous keys it found in the config in a single error statement as otherwise you need to keep launching the run only to keep finding that a extraneous key needs to be removed at a time.

@josejg josejg requested a review from a team as a code owner July 9, 2024 23:47
@eracah eracah self-requested a review July 9, 2024 23:54
Copy link
Contributor

@eracah eracah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I hate guess and check for these types of things

Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mvpatel2000 mvpatel2000 mentioned this pull request Jul 11, 2024
@j316chuck
Copy link
Contributor

j316chuck commented Jul 11, 2024

This PR Is helping me debug too! Let's merge it in :-)

@eracah eracah merged commit 6b256cb into mosaicml:main Jul 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants