Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log extraneous keys #1346

Closed
wants to merge 4 commits into from
Closed

Log extraneous keys #1346

wants to merge 4 commits into from

Conversation

j316chuck
Copy link
Contributor

Description

Add some additional logging for extraneous keys

Testing

Before:

  • mcli logs -f 1-node-mpt-125m-monolithic-fp8-save-resume-Z0AbQR
│   348 │   for key in extraneous_keys:                                        │
│ ❱ 349 │   │   raise ValueError(                                              │
│   350 │   │   │   f'Unused parameter {key} found in cfg. Please check your y │
│   351 │   │   )                                                              │
│   352

After:

  • mcli logs -f 1-node-mpt-125m-monolithic-fp8-save-resume-nqIiUG
Extraneous keys {' ', 'global_seed'}

@j316chuck j316chuck marked this pull request as ready for review July 11, 2024 01:33
@j316chuck j316chuck requested a review from a team as a code owner July 11, 2024 01:33
@mvpatel2000
Copy link
Collaborator

Duplicate of #1344

@mvpatel2000 mvpatel2000 marked this as a duplicate of #1344 Jul 11, 2024
@mvpatel2000 mvpatel2000 deleted the chuck/debug_keys branch July 11, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants