Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not autoresume if a default name is set, only on user defined ones #1588

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Do not autoresume if a default name is set, only on user defined ones #1588

merged 3 commits into from
Oct 11, 2024

Conversation

irenedea
Copy link
Contributor

Follow up on #1571 to make sure this only happens if there is an explicitly defined a run name.

@irenedea irenedea requested a review from a team as a code owner October 11, 2024 20:08
mvpatel2000
mvpatel2000 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor nit

llmfoundry/command_utils/train.py Outdated Show resolved Hide resolved
@irenedea irenedea enabled auto-merge (squash) October 11, 2024 20:17
@irenedea irenedea merged commit c6b7453 into mosaicml:main Oct 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irenedea @mvpatel2000