Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not autoresume if a default name is set, only on user defined ones #1588

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Do not autoresume if a default name is set, only on user defined ones #1588

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7d4534
Do not autoresume if a default name is set, only on user defined ones
irenedea Oct 11, 2024
150cf65
Merge branch 'main' into autoresume2
irenedea Oct 11, 2024
96fda63
add parens
irenedea Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions llmfoundry/command_utils/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,17 +311,21 @@ def train(cfg: DictConfig) -> Trainer:
eval_gauntlet_config = train_cfg.eval_gauntlet or train_cfg.eval_gauntlet_str

# Optional parameters will be set to default values if not specified.
default_run_name: str = os.environ.get('RUN_NAME', 'llm')
run_name: str = train_cfg.run_name if train_cfg.run_name else default_run_name
env_run_name: Optional[str] = os.environ.get('RUN_NAME', None)
run_name: str = (
train_cfg.run_name if train_cfg.run_name else env_run_name
) or 'llm'
is_state_dict_sharded: bool = (
fsdp_config.get('state_dict_type', 'full') == 'sharded'
) if fsdp_config else False
save_latest_filename: str = train_cfg.save_latest_filename if train_cfg.save_latest_filename else 'latest-sharded-rank{rank}' if is_state_dict_sharded else 'latest-rank{rank}.pt'
save_filename: str = train_cfg.save_filename if train_cfg.save_filename else 'ep{epoch}-ba{batch}-rank{rank}.pt'

# Enable autoresume from model checkpoints if possible
is_user_set_run_name: bool = train_cfg.run_name is not None or env_run_name is not None
autoresume_default: bool = False
if train_cfg.save_folder is not None \
if is_user_set_run_name and \
train_cfg.save_folder is not None \
and not train_cfg.save_overwrite \
and not train_cfg.save_weights_only:
autoresume_default = True
Expand Down
Loading