Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove xentropy from pypi #86

Merged
merged 4 commits into from
May 10, 2023
Merged

Remove xentropy from pypi #86

merged 4 commits into from
May 10, 2023

Conversation

mvpatel2000
Copy link
Collaborator

@mvpatel2000 mvpatel2000 commented May 9, 2023 •
edited
Loading

Removes xentropy from setup.py for pypi so we can release. Otherwise, pypi blocks direct dependencies. Uses sed to slice out the xentropy line:

diff --git a/setup.py b/setup.py
index 11d47de..992e795 100644
--- a/setup.py
+++ b/setup.py
@@ -75,7 +75,6 @@ extra_deps['dev'] = [
 extra_deps['gpu'] = [
     'flash-attn==v1.0.3.post0',
     'triton==2.0.0.dev20221202',
-    'xentropy-cuda-lib@git+https://github.com/HazyResearch/flash-attention.git@v0.2.8#subdirectory=csrc/xentropy',
 ]

Also updates error to give a more clear description of what's wrong

@mvpatel2000 mvpatel2000 changed the title Add sed pypi hack Remove xentropy from pypi May 9, 2023
dakinggg
dakinggg approved these changes May 9, 2023
View reviewed changes
.github/workflows/release.yaml Show resolved Hide resolved
@nik-mosaic nik-mosaic self-requested a review May 10, 2023 00:13
@mvpatel2000 mvpatel2000 merged commit 1de8789 into main May 10, 2023
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/fix-pypi branch May 10, 2023 00:33
bmosaicml pushed a commit that referenced this pull request Jun 6, 2023
@dblalock
Update installation instructions in all readmes (#86)
a18f9cf
bmosaicml pushed a commit that referenced this pull request Jun 6, 2023
@mvpatel2000
Remove xentropy from pypi (#86)
c9f112e 
* add sed

* disable lint

* fix version

* fix version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik-mosaic nik-mosaic nik-mosaic approved these changes

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvpatel2000 @dakinggg @nik-mosaic